232447 - "GetBugLink() called with non-integer bug number" error on bug 65697

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

When I try to view bug 65697 I get the following error:

Internal Error
	  	

Bugzilla has suffered an internal error. Please save this page and send it to
[e-mail] with details of what you were doing at the time this message
appeared.
undef error - GetBugLink() called with non-integer bug number at
/usr/lib/perl5/5.6.1/CGI/Carp.pm line 312.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Looks like a missing duplicate record in the duplicates table.  I can fix the
record, but should Bugzilla really die when this happens or merely warn() of the
problem and show the bug anyway?  That seems like a more user friendly approach,
since it lets the user see what is likely to be useful information, and if we
insert something about the bug number being missing we can find the problem
faster when they complain about it.

Of course, if we had referential integrity this wouldn't be a problem, except if
the code was buggy, which is possible, so we should plan for this possibility.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: notes missing/invalid bug number instead of dying

Here's a fix that notes a missing or invalid bug number in the page rather than
dying with an error.

Comment 3

[Dave Miller [:justdave]]

Ummm...  I could swear there was another bug for this somewhere...  I patched
this on Bugscape back in March.  :)

Comment 4

[Dave Miller [:justdave]]

Comment on attachment 140086 [details] [diff] [review]
patch v1: notes missing/invalid bug number instead of dying

And this is essentially the same thing I did on Bugscape.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Checking in globals.pl;
/cvsroot/mozilla/webtools/bugzilla/globals.pl,v  <--  globals.pl
new revision: 1.253; previous revision: 1.252
done