Closed Bug 232447 Opened 19 years ago Closed 19 years ago

"GetBugLink() called with non-integer bug number" error on bug 65697

Categories

(Bugzilla :: Creating/Changing Bugs, defect)

defect
Not set
blocker

Tracking

()

RESOLVED FIXED
Bugzilla 2.18

People

(Reporter: myk, Assigned: myk)

References

Details

Attachments

(1 file)

When I try to view bug 65697 I get the following error:

Internal Error
	  	

Bugzilla has suffered an internal error. Please save this page and send it to
myk@mozilla.org with details of what you were doing at the time this message
appeared.
undef error - GetBugLink() called with non-integer bug number at
/usr/lib/perl5/5.6.1/CGI/Carp.pm line 312.
Looks like a missing duplicate record in the duplicates table.  I can fix the
record, but should Bugzilla really die when this happens or merely warn() of the
problem and show the bug anyway?  That seems like a more user friendly approach,
since it lets the user see what is likely to be useful information, and if we
insert something about the bug number being missing we can find the problem
faster when they complain about it.

Of course, if we had referential integrity this wouldn't be a problem, except if
the code was buggy, which is possible, so we should plan for this possibility.
Here's a fix that notes a missing or invalid bug number in the page rather than
dying with an error.
Attachment #140086 - Flags: review?(justdave)
Ummm...  I could swear there was another bug for this somewhere...  I patched
this on Bugscape back in March.  :)
Comment on attachment 140086 [details] [diff] [review]
patch v1: notes missing/invalid bug number instead of dying

And this is essentially the same thing I did on Bugscape.
Attachment #140086 - Flags: review?(justdave) → review+
Checking in globals.pl;
/cvsroot/mozilla/webtools/bugzilla/globals.pl,v  <--  globals.pl
new revision: 1.253; previous revision: 1.252
done
Status: NEW → RESOLVED
Closed: 19 years ago
Flags: approval+
Resolution: --- → FIXED
Target Milestone: --- → Bugzilla 2.18
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.