Closed
Bug 232483
Opened 21 years ago
Closed 20 years ago
NSS 3.9.1 needs a new release of DBM (DBM 1.7)
Categories
(NSS :: Build, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
3.10
People
(Reporter: nelson, Assigned: wtc)
References
Details
Attachments
(1 file, 1 obsolete file)
7.17 KB,
patch
|
nelson
:
review+
|
Details | Diff | Splinter Review |
NSS 3.9.1 want to include the fix for DBM bug 230159, which is now fixed on the DBM_1_6_BRANCH. So, a DBM 1.7 needs to be released (I think, or maybe 1.6.x ?). This bug exists to track that activity.
Assignee | ||
Comment 1•21 years ago
|
||
This patch is Nelson's fix for bug 230159 adapted for the trunk of mozilla/dbm. The trunk of mozilla/dbm is suitable for the next DBM release (1.7). The only differences between the trunk and the DBM_1_6_BRANCH are: 1. Makefile changes: since we build mozilla/dbm using coreconf, we don't care about the makefile changes. 2. OS/2 changes: it appears that the trunk no longer supports IBM's VACPP compiler for OS/2. Whether DBM 1.7 is based on the trunk or the DBM_1_6_BRANCH, we need to check in this patch on the trunk, so that the Mozilla trunk is using the same DBM as we (the NSS team) do.
Assignee | ||
Comment 2•21 years ago
|
||
Comment on attachment 141205 [details] [diff] [review] Patch to land DBM_1_6_BRANCH onto the trunk Nelson, please verify that I correctly carried your fix from DBM_1_6_BRANCH to the trunk. I tried very hard to verify that hdestroy() can destroy a partially created hash table. But the code is very complicated so I gave up. I hope you have already verified this point.
Attachment #141205 -
Flags: review?(MisterSSL)
Comment 3•21 years ago
|
||
Wan-Teh, The trunk of the Mozilla browser may not officially support VACPP, but as of yesterday the NSS tip, NSPR tip and dbm tip were still building with VACPP on my home box, although I did not test to see how the binaries ran.
Assignee | ||
Comment 4•21 years ago
|
||
Removed the comment "We can't use fcntl because of NFS bugs. SIGH", which described the #if 0 block of code that was deleted.
Attachment #141205 -
Attachment is obsolete: true
Assignee | ||
Updated•21 years ago
|
Attachment #141205 -
Flags: review?(MisterSSL)
Assignee | ||
Updated•21 years ago
|
Attachment #141207 -
Flags: review?(MisterSSL)
Reporter | ||
Comment 5•21 years ago
|
||
Comment on attachment 141207 [details] [diff] [review] Patch v1.1 I confirm that you correctly carried my patch from the branch to the trunk. The few remaining differences in this source file, between the branch and the trunk (with this patch applied) appear to affect only OS2. There are other source files that differ between the trunk and the branch, whose differences affect OS2, e.g. mcom_db.h, mktemp.c, ndbm.c (which we don't build for NSS, IIRC). I cannot say whether trunk or branch is better for OS/2, but I would guess it is the branch.
Attachment #141207 -
Flags: review?(MisterSSL) → review+
Reporter | ||
Comment 6•21 years ago
|
||
Adding another OS/2 afficianado to the CC list, who may be able to advise on the differences for OS/2 between the branch and the trunk, as built with NSS's makefiles in mozilla/security/dbm.
Reporter | ||
Updated•20 years ago
|
Priority: -- → P1
Target Milestone: --- → 3.9.5
Comment 7•20 years ago
|
||
Mass reassign of 3.9.5 target bugs to 3.9.6 .
Target Milestone: 3.9.5 → 3.9.6
Reporter | ||
Comment 8•20 years ago
|
||
The plan is to build DBM and tag it with an NSS tag when NSS 3.10 is released (I think we should also tag the Beta 1 build). DBM will not be designated DBM 1.7, but will be designated 3.10 (part of NSS). So I think we can mark this as fixed without releasing DBM 1.7, per se'. Do you agree, Wan-Teh?
Target Milestone: 3.9.6 → 3.10
Assignee | ||
Comment 9•20 years ago
|
||
Agreed. Starting in NSS 3.10, DBM will be an integral part of NSS and won't be available as a separate binary component.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•