232483 - NSS 3.9.1 needs a new release of DBM (DBM 1.7)

Status: RESOLVED FIXED

(NSS :: Build, defect, P1)

Description

[Nelson Bolyard (seldom reads bugmail)]

NSS 3.9.1 want to include the fix for DBM bug 230159, which is now fixed
on the DBM_1_6_BRANCH.  

So, a DBM 1.7 needs to be released (I think, or maybe 1.6.x ?).

This bug exists to track that activity.

Comment 1

[Wan-Teh Chang]

Attachment: Patch to land DBM_1_6_BRANCH onto the trunk

This patch is Nelson's fix for bug 230159 adapted
for the trunk of mozilla/dbm.

The trunk of mozilla/dbm is suitable for the next
DBM release (1.7).  The only differences between
the trunk and the DBM_1_6_BRANCH are:
1. Makefile changes: since we build mozilla/dbm
using coreconf, we don't care about the makefile
changes.
2. OS/2 changes: it appears that the trunk no
longer supports IBM's VACPP compiler for OS/2.

Whether DBM 1.7 is based on the trunk or the
DBM_1_6_BRANCH, we need to check in this patch
on the trunk, so that the Mozilla trunk is using
the same DBM as we (the NSS team) do.

Comment 2

[Wan-Teh Chang]

Comment on attachment 141205 [details] [diff] [review]
Patch to land DBM_1_6_BRANCH onto the trunk

Nelson, please verify that I correctly carried your
fix from DBM_1_6_BRANCH to the trunk.

I tried very hard to verify that hdestroy() can
destroy a partially created hash table.  But the
code is very complicated so I gave up.	I hope
you have already verified this point.

Comment 3

[Julien Pierre]

Wan-Teh,

The trunk of the Mozilla browser may not officially support VACPP, but as of
yesterday the NSS tip, NSPR tip and dbm tip were still building with VACPP on my
home box, although I did not test to see how the binaries ran.

Comment 4

[Wan-Teh Chang]

Attachment: Patch v1.1

Removed the comment "We can't use fcntl because of NFS bugs. SIGH",
which described the #if 0 block of code that was deleted.

Comment 5

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 141207 [details] [diff] [review]
Patch v1.1

I confirm that you correctly carried my patch from the branch to the trunk. 
The few remaining differences in this source file, between the branch and the
trunk (with this patch applied) appear to affect only OS2.

There are other source files that differ between the trunk and the branch,
whose differences affect OS2, e.g. mcom_db.h, mktemp.c, ndbm.c (which we don't
build for NSS, IIRC).  

I cannot say whether trunk or branch is better for OS/2, but I	would guess it
is the branch.

Comment 6

[Nelson Bolyard (seldom reads bugmail)]

Adding another OS/2 afficianado to the CC list, who may be able to advise
on the differences for OS/2 between the branch and the trunk, as built
with NSS's makefiles in mozilla/security/dbm.

Comment 7

[Julien Pierre]

Mass reassign of 3.9.5 target bugs to 3.9.6 .

Comment 8

[Nelson Bolyard (seldom reads bugmail)]

The plan is to build DBM and tag it with an NSS tag when NSS 3.10 is
released (I think we should also tag the Beta 1 build).  DBM will not 
be designated DBM 1.7, but will be designated 3.10 (part of NSS).
So I think we can mark this as fixed without releasing DBM 1.7, per se'.

Do you agree, Wan-Teh?

Comment 9

[Wan-Teh Chang]

Agreed.  Starting in NSS 3.10, DBM will be an
integral part of NSS and won't be available
as a separate binary component.