232830 - cannot make bugzilla forget a saved query that ends with a '+'

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Darin Fisher]

cannot make bugzilla forget a saved query that ends with a '+'

1) save a query named "x+"
2) load the query
3) click "Forget Search 'x+'"

page comes up that says "OK, the x  query is gone."

the extra space after the "x" is intentional... copy-paste of the actual output
generated that, which might be a clue as to what is wrong.

i have a couple of queries that end with '+' and since the recent bugzilla
upgrade, i'm no longer able to delete them.

Comment 1

[Gervase Markham [:gerv]]

I appear to be looking after these...

Gerv

Comment 2

[Gervase Markham [:gerv]]

Attachment: Patch v.1

This fixes the obvious ones; see my message to developers@ for more guidance.

Gerv

Comment 3

[Christian Reis]

Are we supposed to ignore

  Index: template/en/default/pages/saved-searches.html.tmpl

-- ? If so, you have r=kiko on the simple html/url_quote swaps there.

Comment 4

[Gervase Markham [:gerv]]

kiko: thanks for the review :-) The template you mention is a b.m.o.-specific
template which also needs fixing.

Requesting approval.

Gerv

Comment 5

[timeless]

Comment on attachment 140441 [details] [diff] [review]
Patch v.1

> The template you mention is a b.m.o.-specific template which also needs fixing.

Index: template/en/default/pages/saved-searches.html.tmpl
@@ -0,0 +1,43 @@
+[%# [e-mail] %]
...
+  # The Original Code is the Bugzilla Bug Tracking System.
...
+  # The Initial Developer of the Original Code is Netscape Communications
+  # Corporation. Portions created by Netscape are
+  # Copyright (C) 1998 Netscape Communications Corporation. All
+  # Rights Reserved.
is this code derivative of some code by netscape circa 1998? if not would you
please please please use the boilerplates?

if it is, would you please cite the file from which you're deriving your
changes?
+  # Contributor(s): Gervase Markham <[e-mail]>
don't most people put the contributors on lines following the heading? :)

Comment 6

[Gervase Markham [:gerv]]

> is this code derivative of some code by netscape circa 1998?

It's arguably derived from a file with that original code attribution, yes. 

> don't most people put the contributors on lines following the heading? :)

Either style is acceptable.

Gerv

Comment 7

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 140441 [details] [diff] [review]
Patch v.1

r=myk without saved-searches.html

Comment 8

[Gervase Markham [:gerv]]

Fixed.

Checking in template/en/default/reports/edit-series.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/edit-series.html.tmpl,v
 <--  edit-series.html.tmpl
new revision: 1.4; previous revision: 1.3
done
Checking in template/en/default/reports/create-chart.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/create-chart.html.tmpl,v
 <--  create-chart.html.tmpl
new revision: 1.7; previous revision: 1.6
done
Checking in template/en/default/list/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/list.html.tmpl,v 
<--  list.html.tmpl
new revision: 1.20; previous revision: 1.19
done

Gerv