Closed Bug 233091 Opened 21 years ago Closed 20 years ago

In <FilterEditor.js>, "Warning: assignment to undeclared variable targetUri"

Categories

(MailNews Core :: Filters, defect)

Product:
MailNews Core
Component:
Filters
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla1.8alpha2

People

(Reporter: sgautherie, Assigned: sgautherie)

References

Details

(Keywords: fixed1.7.5)

Attachments

(1 file, 2 obsolete files)

(Av3) <FilterEditor.js> [Checked in: Comment 9]
4.37 KB, patch
neil
: review+
Henry.Jia
: superreview+
asa
: approval-aviary+
mkaply
: approval1.7.5+
Details | Diff | Splinter Review 
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6) Gecko/20040113] (W98SE)

{
Warning: assignment to undeclared variable targetUri
Source File: chrome://messenger/content/FilterEditor.js
Line: 416
}

Reproductible: 100%
1. MailNews > Tools > Message Filters...
2. Edit > Move to folder (change the destination) > OK
Attached patch (Av1) <FilterEditor.js> (obsolete) — — Splinter Review 
Bug fix, plus |var str| removal.
Assignee: sspitzer → gautheri
Status: NEW → ASSIGNED
Attachment #140623 - Flags: review?(neil.parkwaycc.co.uk)
Comment on attachment 140623 [details] [diff] [review]
(Av1) <FilterEditor.js>

Sorry, I can't give + to patches that use window.alert - either don't remove
var str, or change it to use the prompt service.
Attachment #140623 - Flags: review?(neil.parkwaycc.co.uk) → review-
Attachment #140623 - Attachment is obsolete: true
Attached patch (Av2) <FilterEditor.js> (obsolete) — — Splinter Review 
Av1, with comment 2 suggestion(s).
Comment on attachment 140769 [details] [diff] [review]
(Av2) <FilterEditor.js>


I copied and adapted |GetPromptService()| from an LXR search...
Attachment #140769 - Flags: review?(neil.parkwaycc.co.uk)
Comment on attachment 140769 [details] [diff] [review]
(Av2) <FilterEditor.js>

>+      var promptService = GetPromptService();
>+      var promptService = GetPromptService();
>+      var promptService = GetPromptService();
Oops, function saveFilter() has three declarations of promptService...

>+                     .getService()
>+                     .QueryInterface(Components.interfaces.nsIPromptService);
Please simplify this to .getService(Components.interfaces.nsIPromptService);
Attachment #140769 - Flags: review?(neil.parkwaycc.co.uk) → review-
Attachment #140769 - Attachment is obsolete: true
Attachment #140815 - Flags: review?(neil.parkwaycc.co.uk)
OS: Windows 98 → All
Hardware: PC → All
Attachment #140815 - Flags: review?(neil.parkwaycc.co.uk) → review+
Attachment #140815 - Flags: superreview?(mscott)
Blocks: 219122
Comment on attachment 140815 [details] [diff] [review]
(Av3) <FilterEditor.js>
[Checked in: Comment 9]

No super-review from <mscott@mozilla.org> since "2004-02-07" :-(
Attachment #140815 - Flags: superreview?(mscott) → superreview?(Henry.Jia)
Comment on attachment 140815 [details] [diff] [review]
(Av3) <FilterEditor.js>
[Checked in: Comment 9]

sr = Henry
Attachment #140815 - Flags: superreview?(Henry.Jia) → superreview+
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Attachment #140815 - Attachment description: (Av3) <FilterEditor.js> → (Av3) <FilterEditor.js> [Checked in: Comment 9]
Attachment #140815 - Attachment is obsolete: true
Target Milestone: --- → mozilla1.8alpha2
Comment on attachment 140815 [details] [diff] [review]
(Av3) <FilterEditor.js>
[Checked in: Comment 9]

approval1.7.3=?:
This is "needed" to apply patch for bug 219122 to the branch too...
(checked in in v1.8a2: no regression so far...)
Attachment #140815 - Flags: approval1.7.3?
Comment on attachment 140815 [details] [diff] [review]
(Av3) <FilterEditor.js>
[Checked in: Comment 9]

a=mkaply
Attachment #140815 - Flags: approval1.7.3? → approval1.7.3+
Keywords: fixed1.7.3
Comment on attachment 140815 [details] [diff] [review]
(Av3) <FilterEditor.js>
[Checked in: Comment 9]

David:
{{
I think I remember that Aviary branch is synchronized with v1.7 branch
"automatically",
or should I request approval for explicit checkin ?
}}
Well, asking for 'approval-aviary=?', as needed for bug 219122: dismiss it
and/or explain if this is not needed/appropriate.
Thanks.
Attachment #140815 - Flags: approval-aviary?
Comment on attachment 140815 [details] [diff] [review]
(Av3) <FilterEditor.js>
[Checked in: Comment 9]

a=asa for aviary checkin.
Attachment #140815 - Flags: approval-aviary? → approval-aviary+
Product: MailNews → Core
(In reply to comment #13)
> (From update of attachment 140815 [details] [diff] [review] [edit])
> a=asa for aviary checkin.

This never made it to the aviary1.0 branch:
from bug 219122 comment 32
{{
not relevant to aviary.
}}
Attachment #140815 - Attachment is obsolete: false
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: