233091 - In <FilterEditor.js>, "Warning: assignment to undeclared variable targetUri"

Status: RESOLVED FIXED

(MailNews Core :: Filters, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6) Gecko/20040113] (W98SE)

{
Warning: assignment to undeclared variable targetUri
Source File: chrome://messenger/content/FilterEditor.js
Line: 416
}

Reproductible: 100%
1. MailNews > Tools > Message Filters...
2. Edit > Move to folder (change the destination) > OK

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) <FilterEditor.js>

Bug fix, plus |var str| removal.

Comment 2

[[e-mail]]

Comment on attachment 140623 [details] [diff] [review]
(Av1) <FilterEditor.js>

Sorry, I can't give + to patches that use window.alert - either don't remove
var str, or change it to use the prompt service.

Comment 3

[Serge Gautherie (:sgautherie)]

Attachment: (Av2) <FilterEditor.js>

Av1, with comment 2 suggestion(s).

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 140769 [details] [diff] [review]
(Av2) <FilterEditor.js>


I copied and adapted |GetPromptService()| from an LXR search...

Comment 5

[[e-mail]]

Comment on attachment 140769 [details] [diff] [review]
(Av2) <FilterEditor.js>

>+      var promptService = GetPromptService();
>+      var promptService = GetPromptService();
>+      var promptService = GetPromptService();
Oops, function saveFilter() has three declarations of promptService...

>+                     .getService()
>+                     .QueryInterface(Components.interfaces.nsIPromptService);
Please simplify this to .getService(Components.interfaces.nsIPromptService);

Comment 6

[Serge Gautherie (:sgautherie)]

Attachment: (Av3) <FilterEditor.js> [Checked in: Comment 9]

Av2, with comment 5 suggestion(s).

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 140815 [details] [diff] [review]
(Av3) <FilterEditor.js>
[Checked in: Comment 9]

No super-review from <[e-mail]> since "2004-02-07" :-(

Comment 8

[Henry Jia]

Comment on attachment 140815 [details] [diff] [review]
(Av3) <FilterEditor.js>
[Checked in: Comment 9]

sr = Henry

Comment 9

[[e-mail]]

Fix checked in.

Comment 10

[Serge Gautherie (:sgautherie)]

Comment on attachment 140815 [details] [diff] [review]
(Av3) <FilterEditor.js>
[Checked in: Comment 9]

approval1.7.3=?:
This is "needed" to apply patch for bug 219122 to the branch too...
(checked in in v1.8a2: no regression so far...)

Comment 11

[Mike Kaply [:mkaply]]

Comment on attachment 140815 [details] [diff] [review]
(Av3) <FilterEditor.js>
[Checked in: Comment 9]

a=mkaply

Comment 12

[Serge Gautherie (:sgautherie)]

Comment on attachment 140815 [details] [diff] [review]
(Av3) <FilterEditor.js>
[Checked in: Comment 9]

David:
{{
I think I remember that Aviary branch is synchronized with v1.7 branch
"automatically",
or should I request approval for explicit checkin ?
}}
Well, asking for 'approval-aviary=?', as needed for bug 219122: dismiss it
and/or explain if this is not needed/appropriate.
Thanks.

Comment 13

[Asa Dotzler [:asa]]

Comment on attachment 140815 [details] [diff] [review]
(Av3) <FilterEditor.js>
[Checked in: Comment 9]

a=asa for aviary checkin.

Comment 14

[Serge Gautherie (:sgautherie)]

(In reply to comment #13)
> (From update of attachment 140815 [details] [diff] [review] [edit])
> a=asa for aviary checkin.

This never made it to the aviary1.0 branch:
from bug 219122 comment 32
{{
not relevant to aviary.
}}