233153 - symlinking to mozilla startup script broken

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Andrew Schultz]

after the checkin for bug 230468, symlinking to mozilla startup script is
broken.  At startup, I get:
mozilla-bin: error while loading shared libraries: libmozjs.so: cannot open
shared object file: No such file or directory

This is happening because the mozilla script now sources the run-mozilla.sh
script.  When run-mozilla.sh was executed, run-mozilla.sh could get the real
mozilla directory from `dirname $0`.  Now $0 is the path of the symlink.

I'll attach a patch that at least gets things working again.

Comment 1

[Andrew Schultz]

Attachment: patch

this just sets MOZ_DIST_BIN with the mozilla script instead of re-sniffing it
within run-mozilla.sh

Comment 2

[Malcolm Rowe]

*** Bug 233035 has been marked as a duplicate of this bug. ***

Comment 3

[Andrew Schultz]

symlinking has worked since ~1.1, and I think people use it a lot (3 people have
noticed it so far).  They're going to be unhappy if it doesn't work in 1.7a.

Comment 4

[Andrew Schultz]

Attachment: patch v2

run-mozilla.sh still needs to set MOZ_DIST_BIN if it's not already set (if
run-mozilla.sh gets invoked directly).

Comment 5

[Roland Mainz]

Comment on attachment 140675 [details] [diff] [review]
patch v2

Ouch. Symlinks. Horrible. ;-(

I think the issue can be solved much easier, patch coming up in  afew secs...

Comment 6

[Roland Mainz]

Attachment: Cure for the mess, patch for 2003-02-04-trunk

Comment 7

[Andrew Schultz]

Comment on attachment 140676 [details] [diff] [review]
Cure for the mess, patch for 2003-02-04-trunk

how about "exec"?  that's what was there before.  Is there any advantage to not
exec'ing?

Comment 8

[Roland Mainz]

Andrew Schultz wrote:
> (From update of attachment 140676 [details] [diff] [review])
> how about "exec"?  that's what was there before.  Is there any advantage to 
> not exec'ing?

"exec" replaces the current shell process with the process being launched. After
that no further line will be executed in the shell script - which means the
shutdown scripts will not be run anymore.

Comment 9

[Andrew Schultz]

Comment on attachment 140676 [details] [diff] [review]
Cure for the mess, patch for 2003-02-04-trunk

ah, yes.  exec would prevent the "stop" scripts from working.  and much simpler
than what I had.

Comment 10

[Roland Mainz]

*** Bug 233097 has been marked as a duplicate of this bug. ***

Comment 11

[Daniel (Leaf) Nunes]

Comment on attachment 140676 [details] [diff] [review]
Cure for the mess, patch for 2003-02-04-trunk

ceding superreview of this to bsmedberg (don't have a linux machine handy to
test).

Comment 12

[Jim Brown]

This patch solves the problem in bug 233097.

Comment 13

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in

Comment 14

[lhecking]

*** Bug 233257 has been marked as a duplicate of this bug. ***

Comment 15

[Sergei Dolgov]

omission of exec killed Mozilla BeOS ability to start from script

https://bugzilla.mozilla.org/show_bug.cgi?id=235691

That's a real pain which prevents me working at BeOS port since march 2004 (!!!!)

I hope if use of "exec" is really prohibited, maybe some wise person can propose
other solution?