233155 - ESC should not close viewSource Window while FAYT (Find As You Type)

Status: VERIFIED FIXED

(Firefox :: General, enhancement)

Description

[Hiro]

User-Agent:       
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; ja-JP; rv:1.7a) Gecko/20040205 Firebird/0.8.0+

An ESC key is pushed, when performing "Find As You Type" on a ViewSource screen
and canceling it.
However, a window will close, without interrupting "Find As You Type."
In this case, in order to see HTML sauce, it is necessary to perform "View Page
Source" again.
This is not good.

Reproducible: Always
Steps to Reproduce:
1.Execute "View Page Source"
2.Execute "Find As You Type" on ViewSource screen.
3.Pushed ESC key.

Actual Results:  
A ViewSource screen closes.

Expected Results:  
A ViewSource screen does not close.
"Find As You Type" is canceled.

Comment 1

[noririty]

Closing by ESC is usually restricted with dialog box which has no taskbar button.
viewSource Window does have it. But I don't know if we should simply disable ESC
key in viewSource Window.
http://lxr.mozilla.org/mozilla/source/toolkit/components/viewsource/content/viewSource.xul#93
Better solution may detect if while FAYT before closing.

Anyway, confirming and changing summary a bit.

Comment 2

[Anbo Motohiko]

Ben removed line #93.
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=MozillaTinderboxAll&branch=HEAD&branchtype=match&dir=mozilla%2Ftoolkit&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=03%2F03%2F2004+16%3A28&maxdate=03%2F03%2F2004+16%3A28&cvsroot=%2Fcvsroot

Comment 3

[Hiro]

This bug is not reproduced.
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; ja-JP; rv:1.7b) Gecko/20040305
Firefox/0.8.0+

Comment 4

[noririty]

v.