233212 - Private colormap not working with gtk2 and/or xft builds

Status: RESOLVED FIXED

(Core Graveyard :: GFX: Gtk, defect)

Description

[tor]

Two problems:

  * gtk2's gdkrgb uses the colormap of the drawable instead of an internal
    global colormap.  We weren't setting the colormap of any of the
    temporary or offscreen pixmaps.

  * xft fonts look odd using a private colormap because Render wasn't
    designed to work with that (uses the global colormap).  Patch
    disables xft's use of Render if using a private colormap.

Comment 1

[tor]

Attachment: fix private colormaps

Comment 2

[tor]

Comment on attachment 140689 [details] [diff] [review]
fix private colormaps

Fixes the problem of not working properly with private colormaps
that cropped up again in gtk2.

Comment 3

[chris hofmann]

Comment on attachment 140689 [details] [diff] [review]
fix private colormaps

a=chofmann for 1.7a

Comment 4

[tor]

Checked in.

Comment 5

[tor]

Attachment: don't set colormap on 1-bit stretch

Comment 6

[tor]

Comment on attachment 141313 [details] [diff] [review]
don't set colormap on 1-bit stretch

Don't try setting the colormap when scaling the alpha mask of
an image.  Prevents spewage of these gdk errors:

(Gecko:26630): Gdk-CRITICAL **: file gdkdraw.c: line 264
(gdk_drawable_set_colormap): assertion `cmap == NULL || gdk_drawable_get_depth
(drawable) == cmap->visual->depth' failed

Comment 7

[Daniel Veditz [:dveditz]]

Comment on attachment 141313 [details] [diff] [review]
don't set colormap on 1-bit stretch

a=dveditz for 1.7a

Comment 8

[chris hofmann]

so is everything checked in here?  lets mark fixed if so. thanks

Comment 9

[tor]

No - still waiting for blizzard's review of the follow-up patch.

Comment 10

[tor]

Checked in.