233250 - replace a spurrious assertion with a warning in nsUNIXCharset.cpp

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Jungshik Shin]

dbaron wrote to me about NS_ASSERTION in nsUNIXCharset.cpp which seems suspicous
to him. It's indeed spurrious. We'd better replace it with a warning.

Comment 1

[Jungshik Shin]

Attachment: patch

Comment 2

[Jungshik Shin]

Comment on attachment 140733 [details] [diff] [review]
patch

asking for r/sr.

Comment 3

[Ben Fowler]

Is there a general mechanism or channel for drawing attention to Warnings,
Assertsions and other debug output that is otiose. My lizards give copious
output that looks like this:

WARNING: empty damage rect: update caller to avoid fcn call overhead, file
../../../../../mozilla/layout/html/base/src/nsFrame.cpp, line 2506
WARNING: empty damage rect: update caller to avoid fcn call overhead, file
../../../../../mozilla/layout/html/base/src/nsFrame.cpp, line 2506
WARNING: empty damage rect: update caller to avoid fcn call overhead, file
../../../../../mozilla/layout/html/base/src/nsFrame.cpp, line 2506
WARNING: empty damage rect: update caller to avoid fcn call overhead, file
../../../../../mozilla/layout/html/base/src/nsFrame.cpp, line 2506
WARNING: empty damage rect: update caller to avoid fcn call overhead, file
../../../../../mozilla/layout/html/base/src/nsFrame.cpp, line 2506
++WEBSHELL == 4
++DOMWINDOW == 4
###!!! ASSERTION: Pixels must be locked here: 'pixelFlags & (1 << 7)', file
../../../../mozilla/gfx/src/mac/nsImageMac.cpp, line 154
Break: at file ../../../../mozilla/gfx/src/mac/nsImageMac.cpp, line 154
###!!! ASSERTION: Pixels must be locked here: 'pixelFlags & (1 << 7)', file
../../../../mozilla/gfx/src/mac/nsImageMac.cpp, line 177
Break: at file ../../../../mozilla/gfx/src/mac/nsImageMac.cpp, line 177
###!!! ASSERTION: Pixels must be locked here: 'pixelFlags & (1 << 7)', file
../../../../mozilla/gfx/src/mac/nsImageMac.cpp, line 154
Break: at file ../../../../mozilla/gfx/src/mac/nsImageMac.cpp, line 154

Now I can easily fix my sources, but who would intersted in such patches?

Comment 4

[Simon Montagu :smontagu]

Comment on attachment 140733 [details] [diff] [review]
patch

r=smontagu

Comment 5

[Jungshik Shin]

thanks. checked in.

re: comment #3. Ben,  I don't think all of them are useless. Actually, I believe
most of them are 'real'. If you're sure some of them are indeed otiose, please
file a new bug along with your patch. Although NS_WARNING and NS_ASSERTION are
noops in opt. build, it's still worth getting rid of them because that would
increase the code readability. 

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Just for reference, I removed the "empty damage rect" assertion, and the "pixels
must be locked" assertion is related to bug 228441 and is pointing out a real
problem.