233282 - t/009bugwords.t should search inside quotes inside directives

Status: NEW

(Bugzilla :: Testing Suite, enhancement, P1)

Description

[Mat]

User-Agent:       
Build Identifier: 

I have changed the "variables.none.tmpl" file to change all occurances 
of "Bugs" etc to "Issues" etc.
Most of the bugs have changed to issues, but the Enter Bug page still says Bug. 

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[Dave Miller [:justdave]]

What version of Bugzilla do you have?

Is there a 009bugwords.t in the t/ directory?  And if so, does running
./runtests.pl --verbose 009
pass?

Comment 2

[Mat]

Running 2.17.6
Yes there is a 009bugwords.t in the t/ directory.
Running runtests by calling "./runtests.pl --verbose 009" from 
the "var/www/html/bugzilla" directory passes ok

"ok
All tests successful.
Files=1, Tests=260, 18 wallclock secs (14.42 cusr +  2.71 csys = 17.13 CPU)"

Comment 3

[Dave Miller [:justdave]]

OK, in that case, I need specific instances, with context.  That 009 test is
supposed to detect those, so if there's something still showing up, it's either
a field name, something that was left intentionally, or the test is broken.

Comment 4

[Mat]

If you open up create.html.tmpl, at the top is the below text

[% PROCESS global/header.html.tmpl
  title = "Enter Issue"
  h2 = "This page lets you enter a new issue into I-Zilla."
  onload="set_assign_to();"
%]

Except I have had to manually change the Bugs to Issues.

Comment 5

[Dave Miller [:justdave]]

I see it.  Thanks!

Gerv, probably not an easy way to test for it showing up inside template strings
like that, is there?

Comment 6

[Gervase Markham [:gerv]]

Not easily. The 009 test was never meant to be exhaustive, just useful. This is
the largest class of remaining ones.

We might be able to extend it to look inside quotes inside directives - I don't
know how hard that would be.

Gerv

Comment 7

[Mat]

As a follow up request, is it possible to templatise (is that a word) all names 
in Bugzilla. E.g. I want to change all mentions of the word "OS" to "Account 
Manager". At present (as far as I know) I have to go an edit all the templates.
"OS" could be added into the variables.none.tmpl meaning I only have to change 
one file

Mat

Comment 8

[Dave Miller [:justdave]]

That's a very good idea, but that should be a new bug. :)

We actually have the field names in template variables already, so it would just
be a matter of using them.

Comment 9

[Gervase Markham [:gerv]]

Well, actually it's not a massively good idea IMO. The field name hash and
related hashes are there for the purposes of _translating_ values which (for
whatever reason) are stored in the database. If we start parameterising any text
which occurs more than once that someone might want to change, we're at the top
of a slippery slope down to having all our text as parameters - which is
something we explicitly decided not to do when formulating our localisation
strategy.

Changing "OS" to "Account Manager" only needs doing in about three or four
files. It's not an onerous task :-)

Gerv

Comment 10

[Mat]

Yeah, but im not just changing the OS. I am putting company specific titles on 
most of the labels.
And if I am, im sure several others want to.

Comment 11

[Gervase Markham [:gerv]]

I'm sure several people want to - and they can all edit the templates in the
same three places. :-) grep is your friend. Now let's focus on what this bug is
really about :-)

Gerv

Comment 12

[Vlad Dascalu]

I've created Bug 236443 for the specific issue reported here, so that we keep
this for the testing suite.

Comment 13

[Vlad Dascalu]

Hrm, didn't want to change the target here.

Comment 14

[timeless]

if the change i'm making isn't something you meant to have happen, then if you
shoot me with an explanation about what i misread.

Comment 15

[Marc Schumann [:Wurblzap]]

*** Bug 280332 has been marked as a duplicate of this bug. ***