233393 - Incorrect mail set when review flags changed

Status: RESOLVED DUPLICATE of bug 99215

(Bugzilla :: Attachments & Requests, defect)

Description

[Boris Zbarsky [:bzbarsky]]

NOTE:  This may be a dup of other bugs on this issue; I can't tell.

VERSION:  Current mozilla.org version

STEPS TO REPRODUCE:
1)  Have two people, A and B, and an attachment
2 [details] [diff] [review])  A and B both load the attachment
3 [details] [diff] [review])  A sets the "sr" flag to "sr+"
4)  B sets the "sr" flag to "sr? A"

EXPECTED RESULTS:  A gets no mail

ACTUAL RESULTS:  A gets two emails
1)  In step 3, he gets a "A has granted A's request for sr" (this part is a dup)
2)  In step 4, he gets a "B has granted A's request for sr" (this part is new)

The worst part is that the last mail claims that the sr flag is set, whereas in
reality it ends up being set to "sr? A"

See log at http://bugzilla.mozilla.org/show_activity.cgi?id=133371

Comment 1

[Frédéric Buclin]

(In reply to comment #0)
> The worst part is that the last mail claims that the sr flag is set, whereas in
> reality it ends up being set to "sr? A"

What we actually need is midair collision protection.


*** This bug has been marked as a duplicate of 99215 ***