233514 - Milestone build returns "0" for BuildID during XPInstall

Status: RESOLVED INVALID

(Firefox :: General, defect)

Description

[Michael O.]

User-Agent:       
Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6) Gecko/20040206 Firefox/0.8

BuildID usually contains the date+hour of a build (e.g. 2004020808), but the
Mozilla Firefox 0.8 milestone returns 0. Previous 0.7+ branch builds returned a
correct BuildID. This will cause extension installers using old detection code
to automatically install to the application folder instead of giving an option
to install to the profile folder.

Reproducible: Always
Steps to Reproduce:
1. "Install" http://www.cosmicat.com/x/build_id.xpi
Actual Results:  
XPInstall alert displays 0 for BuildID

Expected Results:  
XPInstall alert should display the build date+hour for BuildID

Comment 1

[Ali Ebrahim]

Yep, I'm seeing an incorrect BuildID as well, which isn't a program bug, but
rather a problem with the build environment of the person who built the release.
The release version of Firefox was probably built without the following flags
being set, when they should have been set:

MOZILLA_OFFICIAL=1
BUILD_OFFICIAL=1

I'm not sure if this is a bug (because its not code-related). Thus I'm not going
to mark it invalid, but hopefully someone will address this somewhat major issue.

Comment 2

[Krueger Industrial Smoothing]

I do my own nightly builds and I have the following set in .mozconfig:

 MOZILLA_OFFICIAL=1
 BUILD_OFFICIAL=1

and yet the test program listed above returns a BuildID of "0".

Comment 3

[Frederic Bezies]

You have to add those settings to your system and not only in your .mozconfig.

Try to add them there : My Computer / Properties / Advanced / environment
variables / system variables (Rough translation from my french WinXP system)

Comment 4

[Ali Ebrahim]

Current nightlies contain a correct Build ID, so the problem is ostensibly
fixed. Marking as invalid for now.

Comment 5

[Doug Halamay]

See my note in bug 239439, comment 5:
http://bugzilla.mozilla.org/show_bug.cgi?id=239439#c5

It seems that setting MOZILLA_OFFICIAL=1 and BUILD_OFFICIAL=1 also has the side
effect of adding extra files to the builds (mfcembed.exe, winembed.exe, etc.)
that were not previously in nightly builds.

Comment 6

[Ali Ebrahim]

(In reply to comment #5)
> See my note in bug 239439, comment 5:
> http://bugzilla.mozilla.org/show_bug.cgi?id=239439#c5
> 
> It seems that setting MOZILLA_OFFICIAL=1 and BUILD_OFFICIAL=1 also has the side
> effect of adding extra files to the builds (mfcembed.exe, winembed.exe, etc.)
> that were not previously in nightly builds.

Yes, that is correct. But this is not a bug, it is by design. However, those
extra files are not required to run Firefox, and you can just delete them if you
wish.