233611 - Download Manager Closes after download is cancelled, retried, and cancelled again

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[Alex Hobbs]

User-Agent:       
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040206 Firefox/0.8

If there is a download running, it is cancelled, retried, and then cancelled
again, the download cancels and closes the download manager.

Reproducible: Always
Steps to Reproduce:
1. Start download
2. Cancel
3. Retry
4. Cancel again

Actual Results:  
Download manager erroneously closed.

Expected Results:  
Cancelled the download and remained open.

Comment 1

[Charles Fenwick]

I've been checking this out and I'm not quite sure what the complaint is.

I think I am confused by the 'retried and cancelled again' part because when I
start downloading something (with the download manager closed when I start the
download), and hit cancel then the download manager closes.

I tried this with the download manager already open, and I was able to cancel
and restart the download to my heart's content without the download manager closing.

Comment 2

[Ali Ebrahim]

There is definitely some incorrect behaviour here. Following the steps to repro
in comment 0, when I started the download, it popped up the download manager.
When I clicked cancel, the download cancelled but the download manager stayed
open (this should happen).

When I clicked retry, the download restarted and stayed open. When I hit cancel
again, it cancelled the download and closed the download manager (the download
manager shouldn't have closed).

This happened in Firefox 0.8 on Windows and Linux.

--> All/All

Comment 3

[chris sabo]

Tried. tried many times in a row with different downloads.  Was unable to produce

Comment 4

[Phil Ringnalda (:philor)]

To reproduce, you need to have "Close the Download Manager when all downloads
are complete" checked. Confirmed still present in 20051006 trunk.

Comment 5

[Son Le]

Attachment: patch v0

Don't send 'dl-done' notifications for cancelled downloads.

Comment 6

[[e-mail]]

Comment on attachment 210841 [details] [diff] [review]
patch v0

Sorry, this isn't my area.

Comment 7

[Phil Ringnalda (:philor)]

Since you're patching in toolkit, per http://www.mozilla.org/projects/toolkit/review.html you probably want review from mconnor (unless biesi's added toolkit to all his other responsibilities recently).

Comment 8

[Son Le]

Comment on attachment 210841 [details] [diff] [review]
patch v0

Didn't see that page. Updating review request.

Thanks.

Comment 9

[Mike Connor [:mconnor]]

Comment on attachment 210841 [details] [diff] [review]
patch v0

r+a=me

Comment 10

[Son Le]

Checkin please.

Comment 11

[:Gavin Sharp [email: [e-mail]]]

mozilla/toolkit/components/downloads/src/nsDownloadManager.cpp 1.68