Javascript strict warning in cookieViewer.js

RESOLVED FIXED in mozilla1.7beta

Status

()

Core
Networking: Cookies
--
minor
RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: HJ, Assigned: mconnor)

Tracking

Trunk
mozilla1.7beta
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 obsolete attachment)

(Reporter)

Description

14 years ago
Warning: function CookieSelected does not always return a value
Source File: chrome://communicator/content/wallet/CookieViewer.js
Line: 322, Column: 10
Source Code:
    return;

Warning: function CookieSelected does not always return a value
Source File: chrome://communicator/content/wallet/CookieViewer.js
Line: 352, Column: 13
Source Code:
  return true;

Note: the line numbers and columns may vary from build to build.

http://lxr.mozilla.org/seamonkey/source/extensions/wallet/cookieviewer/resources/content/CookieViewer.js#322

This bug can be fixed like this:
-     return;
+     return false;
(Assignee)

Comment 1

14 years ago
-> me, YACMB
Assignee: darin → mconnor
Summary: Javascript strict warning in cookieViewer.js → Javascript strict warning in cookieViewer.js
(Assignee)

Updated

14 years ago
Depends on: 234183
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7a) Gecko/20040219] (W98SE)

Confirming, and adding another warning:
{{
Warning: function CookieSelected does not always return a value
Source File: chrome://communicator/content/wallet/CookieViewer.js
Line: 322, Column: 10
Source Code:
    return;

Warning: function CookieSelected does not always return a value
Source File: chrome://communicator/content/wallet/CookieViewer.js
Line: 352, Column: 13
Source Code:
  return true;


Warning: redeclaration of var p
Source File: chrome://communicator/content/wallet/CookieViewer.js
Line: 581, Column: 13
Source Code:
    for (var p=0; p<deletedPermissions.length; p++)
}}
Severity: normal → minor
Summary: Javascript strict warning in cookieViewer.js → In <CookieViewer.js>, "3" JavaScript strict Warnings.
Created attachment 143194 [details] [diff] [review]
(Av1) <CookieViewer.js>
[Moved to bug 238080]
Comment on attachment 143194 [details] [diff] [review]
(Av1) <CookieViewer.js>
[Moved to bug 238080]


mike:
Not asking for reviews:
Can you include the |var p| fix in your global patch in bug 234183 ?
(Assignee)

Comment 5

14 years ago
I don't get the redeclaration of var p in a current trunk build... I don't think
there's time before freeze to add more to the combined patch

can you split off the var p thing into a new bug/separate patch and I'll try to
get it in on its own, its not critical though, especially since I don't get that
error...
(Assignee)

Comment 6

14 years ago
reverting original summary, the other error should be filed as a new bug.
Summary: In <CookieViewer.js>, "3" JavaScript strict Warnings. → Javascript strict warning in cookieViewer.js
(Assignee)

Comment 7

14 years ago
fixed as part of bug 234183, checked in 03/09/2004 15:58

Serge, please file that other bug with just the var p patch when you get a chance
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.7beta
Attachment #143194 - Attachment description: (Av1) <CookieViewer.js> → (Av1) <CookieViewer.js> [Moved to bug 238080]
Attachment #143194 - Attachment is obsolete: true
(In reply to comment #7)
> fixed as part of bug 234183, checked in 03/09/2004 15:58
> 
> Serge, please file that other bug with just the var p patch when you get a chance

|var p| part moved to bug 238080.
You need to log in before you can comment on or make changes to this bug.