233910 - Javascript strict warning in cookieViewer.js

Status: RESOLVED FIXED

(Core :: Networking: Cookies, defect)

Description

[HJ]

Warning: function CookieSelected does not always return a value
Source File: chrome://communicator/content/wallet/CookieViewer.js
Line: 322, Column: 10
Source Code:
    return;

Warning: function CookieSelected does not always return a value
Source File: chrome://communicator/content/wallet/CookieViewer.js
Line: 352, Column: 13
Source Code:
  return true;

Note: the line numbers and columns may vary from build to build.

http://lxr.mozilla.org/seamonkey/source/extensions/wallet/cookieviewer/resources/content/CookieViewer.js#322

This bug can be fixed like this:
-     return;
+     return false;

Comment 1

[Mike Connor [:mconnor]]

-> me, YACMB

Comment 2

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7a) Gecko/20040219] (W98SE)

Confirming, and adding another warning:
{{
Warning: function CookieSelected does not always return a value
Source File: chrome://communicator/content/wallet/CookieViewer.js
Line: 322, Column: 10
Source Code:
    return;

Warning: function CookieSelected does not always return a value
Source File: chrome://communicator/content/wallet/CookieViewer.js
Line: 352, Column: 13
Source Code:
  return true;


Warning: redeclaration of var p
Source File: chrome://communicator/content/wallet/CookieViewer.js
Line: 581, Column: 13
Source Code:
    for (var p=0; p<deletedPermissions.length; p++)
}}

Comment 3

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) <CookieViewer.js> [Moved to bug 238080]

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 143194 [details] [diff] [review]
(Av1) <CookieViewer.js>
[Moved to bug 238080]


mike:
Not asking for reviews:
Can you include the |var p| fix in your global patch in bug 234183 ?

Comment 5

[Mike Connor [:mconnor]]

I don't get the redeclaration of var p in a current trunk build... I don't think
there's time before freeze to add more to the combined patch

can you split off the var p thing into a new bug/separate patch and I'll try to
get it in on its own, its not critical though, especially since I don't get that
error...

Comment 6

[Mike Connor [:mconnor]]

reverting original summary, the other error should be filed as a new bug.

Comment 7

[Mike Connor [:mconnor]]

fixed as part of bug 234183, checked in 03/09/2004 15:58

Serge, please file that other bug with just the var p patch when you get a chance

Comment 8

[Serge Gautherie (:sgautherie)]

(In reply to comment #7)
> fixed as part of bug 234183, checked in 03/09/2004 15:58
> 
> Serge, please file that other bug with just the var p patch when you get a chance

|var p| part moved to bug 238080.