"Take bug" on create attachment screen does not send original assignee mail

RESOLVED FIXED in Bugzilla 2.18

Status

()

defect
--
major
RESOLVED FIXED
16 years ago
7 years ago

People

(Reporter: Biesinger, Assigned: justdave)

Tracking

2.17.6
Bugzilla 2.18
Bug Flags:
approval +

Details

Attachments

(1 attachment)

(seen on http://landfill.bugzilla.org/bugzilla-tip/ as well as bmo)

Clicking "Take bug" on the create attachment screen does not send the original
assignee an email. In fact, the orig. assignee is not listed on the "Changes
Submitted" page at all.
I'd guess that the variable $forcecc declared on line 888 and set on line 905,
but never used elsewhere, would be related (it even has a comment "Make sure the
person we are taking the bug from gets mail", but it looks like it's somewhat
false).

http://lxr.mozilla.org/mozilla/source/webtools/bugzilla/attachment.cgi#887
Posted patch Patch v1Splinter Review
Good call, James! :)   We had an API change to the mail code that got missed
there.
Assignee: myk → justdave
Status: NEW → ASSIGNED
Attachment #147018 - Flags: review?(gerv)
Target Milestone: --- → Bugzilla 2.18
Comment on attachment 147018 [details] [diff] [review]
Patch v1

Yeah, I remember sorting this out first time round...

r=gerv - looks good by inspection.

Gerv
Attachment #147018 - Flags: review?(gerv) → review+
Checking in attachment.cgi;
/cvsroot/mozilla/webtools/bugzilla/attachment.cgi,v  <--  attachment.cgi
new revision: 1.55; previous revision: 1.54
done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: approval+
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.