234540 - "Take bug" on create attachment screen does not send original assignee mail

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

(seen on http://landfill.bugzilla.org/bugzilla-tip/ as well as bmo)

Clicking "Take bug" on the create attachment screen does not send the original
assignee an email. In fact, the orig. assignee is not listed on the "Changes
Submitted" page at all.

Comment 1

[James Ross]

I'd guess that the variable $forcecc declared on line 888 and set on line 905,
but never used elsewhere, would be related (it even has a comment "Make sure the
person we are taking the bug from gets mail", but it looks like it's somewhat
false).

http://lxr.mozilla.org/mozilla/source/webtools/bugzilla/attachment.cgi#887

Comment 2

[Dave Miller [:justdave]]

Attachment: Patch v1

Good call, James! :)   We had an API change to the mail code that got missed
there.

Comment 3

[Gervase Markham [:gerv]]

Comment on attachment 147018 [details] [diff] [review]
Patch v1

Yeah, I remember sorting this out first time round...

r=gerv - looks good by inspection.

Gerv

Comment 4

[Dave Miller [:justdave]]

Checking in attachment.cgi;
/cvsroot/mozilla/webtools/bugzilla/attachment.cgi,v  <--  attachment.cgi
new revision: 1.55; previous revision: 1.54
done