incompletely downloaded imap messages can end up in offline store

RESOLVED FIXED

Status

SeaMonkey
MailNews: Backend
RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: Bienvenu, Assigned: Bienvenu)

Tracking

Trunk
x86
Windows 2000

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

14 years ago
One user has reported getting imap messages in the offline store that don't have
some attachments downloaded correctly. The Mime parts on demand version of the
attachment "this part will be downloaded on demand" ends up in the offline
store. I don't know how this happened, exactly, but I suspect that there's some
sort of race condition or contention over
nsImapMailFolder::m_downloadMessageForOfflineUse. We set this appropriately in
nsImapService::DisplayMessage, but other code can come along and change this
before we actually get into the imap protocol code that fetches a message,
especially if urls get queued, etc.
(Assignee)

Comment 1

14 years ago
Created attachment 141554 [details] [diff] [review]
potential fix

in the imap protocol code where we know we're fetching by parts, make sure that
the imap folder doesn't think we should save the msg for offline use.
(Assignee)

Updated

14 years ago
Attachment #141554 - Flags: superreview?(mscott)

Updated

14 years ago
Attachment #141554 - Flags: superreview?(mscott) → superreview+
Summary: imcompletely downloaded imap messages can end up in offline store → incompletely downloaded imap messages can end up in offline store
(Assignee)

Comment 2

14 years ago
fixed on branch
(Assignee)

Comment 3

14 years ago
fixed on trunk.
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.