234553 - incompletely downloaded imap messages can end up in offline store

Status: RESOLVED FIXED

Description

[David :Bienvenu]

One user has reported getting imap messages in the offline store that don't have
some attachments downloaded correctly. The Mime parts on demand version of the
attachment "this part will be downloaded on demand" ends up in the offline
store. I don't know how this happened, exactly, but I suspect that there's some
sort of race condition or contention over
nsImapMailFolder::m_downloadMessageForOfflineUse. We set this appropriately in
nsImapService::DisplayMessage, but other code can come along and change this
before we actually get into the imap protocol code that fetches a message,
especially if urls get queued, etc.

Comment 1

[David :Bienvenu]

Created attachment 141554 [details] [diff] [review]
potential fix

in the imap protocol code where we know we're fetching by parts, make sure that
the imap folder doesn't think we should save the msg for offline use.

Comment 2

[David :Bienvenu]

fixed on branch

Comment 3

[David :Bienvenu]

fixed on trunk.