234763 - crashes by import of bookmark.

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Hiro]

User-Agent:       
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; ja-JP; rv:1.7a) Gecko/20040217 Camino/0.7+

It crashes, when bookmark which contains very long URL like bookmarklet is imported.
Import of bookmark was performed by being the thing of firefox.
bookmarklet has registered the following into bookmark of firefox in advance.

http://www.remus.dti.ne.jp/~a-satomi/bunsyorou/Camino_benriSet/Camino_benriSet_168.tar.gz

Reproducible: Always
Steps to Reproduce:
1.Select "Import bookmarks..."
2.Mozilla Firebird is chosen from a browser selection list.
3.The Import button is pushed.
Actual Results:  
It crashes.


Expected Results:  
bookmark is imported.

Comment 1

[Hiro]

Attachment: Crash log

Comment 2

[Mike Pinkerton (not reading bugmail)]

yet another crash, i'm gonna ifdef-out the code until we can get to it, probably
after 0.9

Comment 3

[Mike Pinkerton (not reading bugmail)]

heehee, wrong bug :)

Comment 4

[Mike Pinkerton (not reading bugmail)]

ok, i was able to fix this. It's got nothing at all to do with long urls, but
one of the bookmarklets has an embedded <a></a> in it and that throws the parser
for a HUGE loop. I was able to make it not crash and recover and get the rest of
the file, but that one bookmarklet is lost and we just can't import it. I think
that's a reasonable compromise.

i'll file a new bug that we can't import bookmarklets with <a> in them.

Comment 5

[Mike Pinkerton (not reading bugmail)]

fixed, and as an added bonus, we're now correctly importing shift_jis-encoded
bookmark files :)

Comment 6

[Hiro]

It came to be able to perform import of bookmark normally.
thanks for quick work!!

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; rv:1.7a) Gecko/20040219 Camino/0.7+