when download a file whose url address is very long, the save dialog misses its buttons (dialog is clipped/cut at the bottom)

NEW
Unassigned

Status

15 years ago
10 years ago

People

(Reporter: eagle.lu, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

15 years ago
User-Agent:       
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; zh-CN; rv:1.4.1) Gecko/20040102

The popup window is mess. User can't find the OK and Cancel buttons.

Reproducible: Always
Steps to Reproduce:
1 open the url:http://www.mozilla.org/quality/networking/testing/datatests.html
2 click the link:"the hats were my idea" in the table

Actual Results:  
an openning dialog displayed,drag the window to the left 
the 'ok' and 'cancel' button can not be find.

In fact, the popup window is mess.



Expected Results:  
User should get a clean window.
(Reporter)

Comment 1

15 years ago
Created attachment 141726 [details] [diff] [review]
I set the max title length of the helper window

Comment 2

15 years ago
Heh that's pretty messed up, honkin' dialog...

Confirmed in:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7a) Gecko/20040218

Firefox has a normal-sized dialog, the title's munged up though, overlapping
characters and such.
Status: UNCONFIRMED → NEW
Component: Browser-General → XP Apps: GUI Features
Ever confirmed: true

Updated

15 years ago
Assignee: general → guifeatures
(Reporter)

Comment 3

15 years ago
Comment on attachment 141726 [details] [diff] [review]
I set the max title length of the helper window

Hi, Bz,
  Can you give r?
Attachment #141726 - Flags: review?(bzbarsky)
Comment on attachment 141726 [details] [diff] [review]
I set the max title length of the helper window

First, if we're going to cut off part of the name we should be cutting off the
beginning, not the end (so the extension (sigh) is visible).

Second, this should be doable with a crop on the XUL element in question, I
would think.
Attachment #141726 - Flags: review?(bzbarsky) → review-
Also, I'm not really a good person to ask for UI reviews... one of the UI peers
would be better.
(Reporter)

Comment 6

15 years ago
Comment on attachment 141726 [details] [diff] [review]
I set the max title length of the helper window

Thanks BZ

David,
  Can you give r?
Attachment #141726 - Flags: review- → review?(hyatt)
(Reporter)

Updated

15 years ago
Attachment #141726 - Attachment is obsolete: true
(Reporter)

Comment 7

15 years ago
Created attachment 142727 [details] [diff] [review]
I cut off the filename from the beginning.

Thanks BZ's comments. I modified the patch according to your comments.
(Reporter)

Comment 8

15 years ago
Comment on attachment 142727 [details] [diff] [review]
I cut off the filename from the beginning.

David,
  Can you give r to this path?
Attachment #142727 - Flags: review?(hyatt)

Updated

15 years ago
Attachment #141726 - Flags: review?(hyatt)

Updated

15 years ago
Attachment #142727 - Flags: review?(hyatt) → review?(neil.parkwaycc.co.uk)

Comment 9

15 years ago
Comment on attachment 142727 [details] [diff] [review]
I cut off the filename from the beginning.

this is not an endorsement, i don't think the patch followed bz's review
comments
Comment on attachment 142727 [details] [diff] [review]
I cut off the filename from the beginning.

crop in the middle and use xul for that.
Attachment #142727 - Flags: review?(neil.parkwaycc.co.uk) → review-
arg, I only now realized that the summary of this bug and this patch are talking
about two different things: Summary about URL, patch about filename.

hm... where do we get the filename for a data: url from?
Created attachment 147633 [details]
screenshot of badly cropped download dialog buttons

The buttons are cropped because the slightly long file name forces a additional
wrap of the text describing the download type. If the file name were extremely
long, long enough to cause an additional wrap, then the buttons would be
completely inaccessable.

I'll attach a comparison screenshot with less cropped buttons because the file
name is short.
Created attachment 147634 [details]
screen shot of less cropped buttons in download dialog

Compare the position of "located at:" within the two screen shots.  In this
example the text has not been wrapped down another line, thus leaving enough
room in the window to show the buttons at the bottom.

Is it possible to make the default size of this dialog box capable of handling
a  a very long file name size?	Even if it were to wrap down two or three
lines?

Comment 15

14 years ago
*** Bug 249830 has been marked as a duplicate of this bug. ***

Comment 16

14 years ago
Interesting solution for croping names can be seen in Apples' Safari.
URL/file name is actually clipped in the midle.
The front and end parts are still visible.
The middle part is substituted by "...".
algorithm:
input: S -input string
       L - requested length 
output: O - output string

if ( lenght(S) < L)
    O=S;
else
    L1 = (L-3)/2; # half of requested string without elipsis
    O = substr(S,0,L1);     # head part
    O .= "...";             # elipsis part
    O .= substr(S,L-L1,L1); # tail part
Product: Core → Mozilla Application Suite

Updated

14 years ago
OS: Linux → All
Summary: when download a file whose url address is very long,the save dialog → when download a file whose url address is very long, the save dialog misses its buttons (dialog is clipped/cut at the bottom)

Comment 17

12 years ago
This problem now exists in Linux+SeaMonkey since 1.0.2 and 1.0.3.  I had never noticed it before and regularly download files.

Shouldn't the window issue a recalculate vertical size and shrink to fit after it has added all its child widgets.

Comment 18

11 years ago
WFM on Mac OS X. I hit the link and the mp3 plays. If I select the 'File'->'Save Page as...' menu, it provides the filename "(audio_mp3 Object)", which is at least reasonable.

Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a7pre) Gecko/2007072901 Minefield/3.0a7pre
Filter "spam" on "guifeatures-nobody-20080610".
Assignee: guifeatures → nobody
QA Contact: general → guifeatures

Updated

10 years ago
Component: XP Apps: GUI Features → UI Design
You need to log in before you can comment on or make changes to this bug.