Closed Bug 234876 Opened 16 years ago Closed 16 years ago
Remove %FORM from token
Change token.cgi to not use %FORM as per bug 225818.
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Target Milestone: --- → Bugzilla 2.18
Attachment #141737 - Flags: review? → review?(jouni)
Comment on attachment 141737 [details] [diff] [review] Changes, V1 Wouldn't it be nicer to avoid all the Bugzilla statements and use a my $cgi = Bugzilla->cgi; in the beginning of the file?
I agree, here is a revised patch. I also changed |Bugzilla->cgi->header();| lines to use the new variable. BTW, those lines were the reason why I used that syntax in this file in the first place..
Attachment #141737 - Attachment is obsolete: true
Attachment #141737 - Flags: review?(jouni)
Comment on attachment 142440 [details] [diff] [review] Changes, V2 (I guess Bugzilla->cgi was used because it was only calls originally) Looks correct, and follows Bugzilla style (as doeditparams.cgi exemplifies, for instance). Make sure the tests run here before comitting.
Attachment #142440 - Flags: review?(kiko) → review+
It was only *two* calls originally, I say.
Checking in token.cgi; /cvsroot/mozilla/webtools/bugzilla/token.cgi,v <-- token.cgi new revision: 1.21; previous revision: 1.20 done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.