234876 - Remove %FORM from token.cgi

Status: RESOLVED FIXED

(Bugzilla :: User Accounts, defect)

Description

[Teemu Mannermaa (:wicked)]

Change token.cgi to not use %FORM as per bug 225818.

Comment 1

[Teemu Mannermaa (:wicked)]

Attachment: Changes, V1

Comment 2

[Christian Reis]

Comment on attachment 141737 [details] [diff] [review]
Changes, V1

Wouldn't it be nicer to avoid all the Bugzilla statements and use a

my $cgi = Bugzilla->cgi; 

in the beginning of the file?

Comment 3

[Teemu Mannermaa (:wicked)]

Attachment: Changes, V2

I agree, here is a revised patch. I also changed |Bugzilla->cgi->header();|
lines to use the new variable. BTW, those lines were the reason why I used that
syntax in this file in the first place..

Comment 4

[Christian Reis]

Comment on attachment 142440 [details] [diff] [review]
Changes, V2

(I guess Bugzilla->cgi was used because it was only calls originally)

Looks correct, and follows Bugzilla style (as doeditparams.cgi exemplifies, for
instance). Make sure the tests run here before comitting.

Comment 5

[Christian Reis]

It was only *two* calls originally, I say.

Comment 6

[Vlad Dascalu]

Checking in token.cgi;
/cvsroot/mozilla/webtools/bugzilla/token.cgi,v  <--  token.cgi
new revision: 1.21; previous revision: 1.20
done