Closed
Bug 234898
Opened 21 years ago
Closed 21 years ago
Start using $cgi->param in queryhelp.cgi
Categories
(Bugzilla :: Bugzilla-General, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.18
People
(Reporter: wicked, Assigned: wicked)
References
Details
Attachments
(1 file)
923 bytes,
patch
|
kiko
:
review+
|
Details | Diff | Splinter Review |
Eliminate obsolete %FORM vars from queryhelp.cgi by changing them to $cgi->param.
Assignee | ||
Updated•21 years ago
|
Assignee | ||
Comment 1•21 years ago
|
||
Unless I'm missing something, there was no reason to get the value of product
parm so I removed it.
Assignee | ||
Updated•21 years ago
|
Attachment #141751 -
Flags: review?
Assignee | ||
Updated•21 years ago
|
Attachment #141751 -
Flags: review? → review?(kiko)
Comment 2•21 years ago
|
||
Comment on attachment 141751 [details] [diff] [review]
Version 1
I can't seem to disagree with you. I've been fishing through bonsai and the
lines have been here since version 1.1 of the file, though they were never
used, and gerv added a bunch of stuff that ended up clobbering it in 1.2:
http://webtools.mozilla.org/bonsai/cvsblame.cgi?file=mozilla/webtools/bugzilla/
queryhelp.cgi&rev=1.2&root=/cvsroot
(no, cvs diff doesn't work in Bonsai there for some reason). I guess it's
something that was supposed to go in but never did. Yay for no reviews.
Attachment #141751 -
Flags: review?(kiko) → review+
Assignee | ||
Updated•21 years ago
|
Flags: approval?
Target Milestone: --- → Bugzilla 2.18
Comment 3•21 years ago
|
||
uhhh.... okay. :)
Yeah, nuke that unused cruft. ;)
Flags: approval? → approval+
Comment 4•21 years ago
|
||
Checking in queryhelp.cgi;
/cvsroot/mozilla/webtools/bugzilla/queryhelp.cgi,v <-- queryhelp.cgi
new revision: 1.22; previous revision: 1.21
done
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•