235061 - process_bug.cgi should get all show_bug.cgi css stylings

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[Colin Ogilvie [:cso]]

User-Agent:       
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040206 Firefox/0.8

When you make a change to a bug, and process_bug.cgi moves you on to the next
bug, obsolete attachments are not struck through. This is because the CSS file
is not included in the page headers, so it does not apply.

Reproducible: Always
Steps to Reproduce:
1. Change a bug, where when you submit the next bug will have an obsolete patch.
2. Check the Source - no CSS file is included and obsolete patches are not
struckthrough.

Actual Results:  
Obsolete patches not struck through

Expected Results:  
Obsolete patches should be struck through

Comment 1

[Christopher Schmidt]

Example html is at http://lj.crschmidt.net/process_bug.html, which is an example
of a page on http://zilla.livejournal.org, using a very slightly modified
version of 2.17.6 CVS.

Comment 2

[Marc Schumann [:Wurblzap]]

Attachment: Use css/edit_bug.css for process_bug.cgi pages, like show_bug.cgi does

I noted the missing css because the comment headers weren't styled correctly in
process_bug.cgi pages. This patch puts the css/edit_bug.css in, which corrects
both effects.

Comment 3

[Christian Reis]

Comment on attachment 156411 [details] [diff] [review]
Use css/edit_bug.css for process_bug.cgi pages, like show_bug.cgi does

This does fix the problem

Comment 4

[Christian Reis]

This patch does seem weird at first because we're using "somebody else's CSS file".

This is caused because we put content-specific CSS rules in page-specific CSS
files -- it induces us into consistency errors like this one. The CSS filename
should be content-specific. Checking with Myk if he thinks it's time to solve
this, and requesting approval as I move.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Stuff that applies across multiple pages should be put into global.css.

Comment 6

[Marc Schumann [:Wurblzap]]

Attachment: Moving to global.css

Moving styles relevant to this bug from edit_bug.css to global.css leaves
edit_bug.css empty, so I removed it.

Comment 7

[Christian Reis]

Uhm. Wait a minute. Aren't obsolete attachments styled via bz_obsolete, which
already lives in global.css today?

Also, why are you moving the table changes out? I do think they are page-specific..

Comment 8

[Marc Schumann [:Wurblzap]]

(In reply to comment #7)
> Uhm. Wait a minute. Aren't obsolete attachments styled via bz_obsolete, which
> already lives in global.css today?

You're right; morphing.
2.17.6 had no global.css (bz_obsolete was in edit_bug.css), but this bug should
have been marked WORKSFORME when global.css was introduced and took bz_obsolete.
I didn't notice because I focused on bz_comment.

> Also, why are you moving the table changes out? I do think they are
> page-specific..

The table stylings are for the flags array below the CC list, so they are needed
for show_bug as well as for process_bug.

Comment 9

[Christian Reis]

Comment on attachment 156802 [details] [diff] [review]
Moving to global.css

In that case, okay.

Comment 10

[Myk Melez [:myk] [@mykmelez]]

Remember to CVS remove edit_bug.css in conjunction with this patch.

Comment 11

[Vlad Dascalu]

Removing css/edit_bug.css;
/cvsroot/mozilla/webtools/bugzilla/css/edit_bug.css,v  <--  edit_bug.css
new revision: delete; previous revision: 1.7
done
Checking in css/global.css;
/cvsroot/mozilla/webtools/bugzilla/css/global.css,v  <--  global.css
new revision: 1.5; previous revision: 1.4
done
Checking in template/en/default/bug/show.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/show.html.tmpl,v  <--
 show.html.tmpl
new revision: 1.7; previous revision: 1.6
done

Removing css/edit_bug.css;
/cvsroot/mozilla/webtools/bugzilla/css/Attic/edit_bug.css,v  <--  edit_bug.css
new revision: delete; previous revision: 1.7
done
Checking in css/global.css;
/cvsroot/mozilla/webtools/bugzilla/css/global.css,v  <--  global.css
new revision: 1.4.2.1; previous revision: 1.4
done
Checking in template/en/default/bug/show.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/show.html.tmpl,v  <--
 show.html.tmpl
new revision: 1.6.2.1; previous revision: 1.6
done

Comment 12

[Albert Ting]

*** Bug 259650 has been marked as a duplicate of this bug. ***