235287 - whineatnews.pl's comment could be improved

Status: RESOLVED FIXED

(Bugzilla :: Email Notifications, defect)

Description

[Vlad Dascalu]

A comment in whineatnews.pl says 7 days but actually the value is read from the 
whinedays param, so the comment is slightly inaccurate.

Comment 1

[Vlad Dascalu]

Attachment: Version 1

Comment 2

[timeless]

Comment on attachment 142031 [details] [diff] [review]
Version 1

does it look at all bugs or just NEW/REOPENED bugs?

Comment 3

[Vlad Dascalu]

(In reply to comment #2)
> does it look at all bugs or just NEW/REOPENED bugs?

Well it's hard to tell how MySQL works ;-)

Thanks for the quick review!

Comment 4

[Vlad Dascalu]

What I wanted to say in comment #3 is that the answer to the question actually 
depends upon the fact if the table is indexed or not.

The SQL statement has a SELECT ... FROM ... WHERE ..., and inside the WHERE 
clause there are the conditions, including the restriction of resolution to NEW 
and REOPENED as well as the delta time computation.

We could say that it looks only at bugs with the resolution and delta time 
computation in the given margin, and then it sends whiny mail to those, but how 
can you find those if you don't look at all the bugs?

Entering into subtilities like MySQL indexes and stuff can sometimes downgrade 
the expressivity of the sentence.

Comment 5

[Vlad Dascalu]

Checking in whineatnews.pl;
/cvsroot/mozilla/webtools/bugzilla/whineatnews.pl,v  <--  whineatnews.pl
new revision: 1.13; previous revision: 1.12
done