Closed
Bug 235287
Opened 20 years ago
Closed 20 years ago
whineatnews.pl's comment could be improved
Categories
(Bugzilla :: Email Notifications, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.18
People
(Reporter: goobix, Assigned: goobix)
Details
Attachments
(1 file)
683 bytes,
patch
|
timeless
:
review+
|
Details | Diff | Splinter Review |
A comment in whineatnews.pl says 7 days but actually the value is read from the whinedays param, so the comment is slightly inaccurate.
Assignee | ||
Updated•20 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → Bugzilla 2.18
Assignee | ||
Comment 1•20 years ago
|
||
Assignee | ||
Updated•20 years ago
|
Attachment #142031 -
Flags: review?(timeless)
Comment on attachment 142031 [details] [diff] [review] Version 1 does it look at all bugs or just NEW/REOPENED bugs?
Attachment #142031 -
Flags: review?(timeless) → review+
Assignee | ||
Comment 3•20 years ago
|
||
(In reply to comment #2) > does it look at all bugs or just NEW/REOPENED bugs? Well it's hard to tell how MySQL works ;-) Thanks for the quick review!
Flags: approval?
Assignee | ||
Comment 4•20 years ago
|
||
What I wanted to say in comment #3 is that the answer to the question actually depends upon the fact if the table is indexed or not. The SQL statement has a SELECT ... FROM ... WHERE ..., and inside the WHERE clause there are the conditions, including the restriction of resolution to NEW and REOPENED as well as the delta time computation. We could say that it looks only at bugs with the resolution and delta time computation in the given margin, and then it sends whiny mail to those, but how can you find those if you don't look at all the bugs? Entering into subtilities like MySQL indexes and stuff can sometimes downgrade the expressivity of the sentence.
Updated•20 years ago
|
Flags: approval? → approval+
Assignee | ||
Comment 5•20 years ago
|
||
Checking in whineatnews.pl; /cvsroot/mozilla/webtools/bugzilla/whineatnews.pl,v <-- whineatnews.pl new revision: 1.13; previous revision: 1.12 done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•