235531 - cookie/image manager menu in Tools can't work

Status: RESOLVED FIXED

(Core :: Networking: Cookies, defect)

Description

[Robin Lu]

1. open a url in the browser
2. open the javascript console
3. click Tools->Image Manager-><Item that has not been checked>
result:
an error in the javascript consle as:
Error: permissionmanager has no properties
Source File: chrome://cookie/content/cookieNavigatorOverlay.xul
Line: 132
The message box of "permission changed" does not prompt out and the url has not
been added to the manager site lists.

mozilla1.7a does not have the problem. I found it in the lastest trunk which is
due to the onpopupshowing of the menupouup in cookieNavigatorOverlay.xul being
not triggered.

Comment 1

[Mike Connor [:mconnor]]

tested this before I left for work, same thing on yesterday's Win32 trunk build.

-> me, should have a fix up tonight once I figure out what happened

Comment 2

[Mike Connor [:mconnor]]

the checkin for bug 142961 broke this by adding a second onpopupshowing to
taskPopup.

Neil, I remember you complaining about this being a Bad Thing(tm) in a patch for
cookieNavigatorOverlay.xul, yet you let someone add another one?  Maybe we
should move the onpopupshowing="CheckForVisibility()" onto the submenu menupopup
elements to prevent this from happening?  The only concern is that this means
this will get called a fair number of times more, but how much will it affect
real-world perf?

Comment 3

[Mike Connor [:mconnor]]

Attachment: proposed fix

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 142417 [details] [diff] [review]
proposed fix

this will result in a call to initWalletMenuItems() each time the submenu is
shown, but I don't think this is anywhere close to affecting real-world
performance

Comment 5

[[e-mail]]

Comment on attachment 142417 [details] [diff] [review]
proposed fix

This is exactly what should have gone in, sorry for not picking up on this in
the previous patch :-[

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 142417 [details] [diff] [review]
proposed fix

sr=bzbarsky

Comment 7

[Mike Connor [:mconnor]]

checked in 02/29/2004 09:48