235581 - Compiling /widget/src/mac generates warnings

Status: RESOLVED FIXED

(Core Graveyard :: GFX: Mac, defect)

Description

[Ludovic Hirlimann [:Usul]]

a bunch of warnings are generated when you compile /widget/src/mac.

Comment 1

[Ludovic Hirlimann [:Usul]]

Attachment: Cleaning up obvious wrnings

Comment 2

[Ludovic Hirlimann [:Usul]]

seeking review ...

Comment 3

[Simon Fraser [no longer active]]

Comment on attachment 142245 [details] [diff] [review]
Cleaning up obvious wrnings

>Index: nsDragService.cpp
>===================================================================
>RCS file: /cvsroot/mozilla/widget/src/mac/nsDragService.cpp,v
>retrieving revision 1.74
>diff -u -r1.74 nsDragService.cpp
>--- nsDragService.cpp	11 Feb 2004 04:57:07 -0000	1.74
>+++ nsDragService.cpp	25 Feb 2004 16:56:53 -0000
>@@ -273,8 +273,8 @@
>   // see it if you're paying attention, but who pays such close attention?
>   Rect dragRect;
>   ::GetRegionBounds(theDragRgn, &dragRect);
>-  theEvent.where.v = rint(dragRect.top + (dragRect.bottom - dragRect.top) / 2);
>-  theEvent.where.h = rint(dragRect.left + (dragRect.right - dragRect.left) / 2);
>+  theEvent.where.v = rint((double)dragRect.top + ((double)dragRect.bottom - (double)dragRect.top) / 2);
>+  theEvent.where.h = rint((double)dragRect.left + ((double)dragRect.right - (double)dragRect.left) / 2);

Do we really need to convert between integer and floating point here?
Just remove the rint()s.

>Index: nsMacWindow.cpp
>===================================================================
>RCS file: /cvsroot/mozilla/widget/src/mac/nsMacWindow.cpp,v
>retrieving revision 1.139
>diff -u -r1.139 nsMacWindow.cpp
>--- nsMacWindow.cpp	12 Jan 2004 08:25:16 -0000	1.139
>+++ nsMacWindow.cpp	25 Feb 2004 16:57:07 -0000
>@@ -429,7 +429,7 @@
>         vOffset = kWindowTitleBarHeight;
>         break;
> 
>-      case eWindowType_invisible:
>+      default:
>         // don't do anything
>         break;
>     }
>@@ -569,6 +569,7 @@
>                                         {kEventClassWindow, kEventWindowDrawContent} };
>       OSStatus err1 = ::InstallWindowEventHandler ( mWindowPtr,
>           NewEventHandlerUPP(WindowEventHandler), 2, windEventList, this, NULL );
>+	  NS_ASSERTION ( err1 == noErr, "Can't install Window Event han,dler");

Typo in the assertion. And this will still warn in opt builds (where the
assertion
is compiled out).

Otherwise fine. r=sfraser

Comment 4

[Ludovic Hirlimann [:Usul]]

Attachment: Simon's comment taken into account

I removed the uncheked return variables because the three OS calls above did
not check retrun avlue either.

Comment 5

[Ludovic Hirlimann [:Usul]]

Fixing summary.

Comment 6

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 142261 [details] [diff] [review]
Simon's comment taken into account

looks ok. r=pink

Comment 7

[Ludovic Hirlimann [:Usul]]

Biesi, 
could you commit the patch ? I don't have the rights and pink doesn't have time to.

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

patching file nsMacMessagePump.cpp
Hunk #2 succeeded at 824 (offset -8 lines).
patching file nsMacWindow.cpp
Hunk #1 FAILED at 429.
Hunk #2 FAILED at 567.

patching file nsNativeScrollbar.cpp
Hunk #1 FAILED at 101.

sorry, I don't currently have the time to fix these conflicts; but I can check
this in if someone attaches an updated patch

Comment 9

[Ludovic Hirlimann [:Usul]]

Attachment: patch updated to turnk

It applies now

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in, please mark fixed if it is

Comment 11

[Ludovic Hirlimann [:Usul]]

Thanks a lot biesi.