235755 - clean up nsFont::EnumerateFamilies and ValueIncludes

Status: NEW

(Core :: CSS Parsing and Computation, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I want to clean up nsFont::EnumerateFamilies and ValueIncludes in
nsCSSStyleSheet.cpp.  They're similar.

Work in progress is in attachment 142321 [details] [diff] [review] on bug 235089.

In addition to what's there being done in both places, they need to handle
escaped quotes better, I think.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

updated patch, still only nsFont.cpp

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The code in question has actually been copied to a whole bunch of places:

http://lxr.mozilla.org/seamonkey/search?string=Append%28kNullCh%29

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(But EnumerateMediaTypes in nsCSSLoader.cpp probably doesn't need to handle quotes.)

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch (checked in to trunk, 2004-07-17 12:03 -0700)

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 147769 [details] [diff] [review]
patch (checked in to trunk, 2004-07-17 12:03 -0700)

I may as well get this out of my tree.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Codesize on luna:

  libgkgfx.so
  	Total:	        +24 (+24/+0)
  	        +24 (+24/+0)	text (CODE)
  		        +24 (+24/+0)	UNDEF:libgkgfx.so:text
  			        +22	nsFont::EnumerateFamilies(int (*)(nsString const&, int, void*),
void*) const
  			         +2	.nosyms.text
  
  libgklayout.so
  	Total:	       -197 (+213/-410)
  	       -197 (+213/-410)	text (DATA)
  		       -197 (+213/-410)	UNDEF:libgklayout.so:text
  			       +211	ValueIncludes(nsSubstring const&, nsSubstring const&,
nsStringComparator const&)
  			         +2	.nosyms.text
  			       -410	ValueIncludes(nsString const&, nsString const&,
nsStringComparator const&)

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Handling escaped quotes is (to some extent) bug 280443.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information