I want to clean up nsFont::EnumerateFamilies and ValueIncludes in nsCSSStyleSheet.cpp. They're similar. Work in progress is in attachment 142321 [details] [diff] [review] on bug 235089. In addition to what's there being done in both places, they need to handle escaped quotes better, I think.
Created attachment 145058 [details] [diff] [review] patch
The code in question has actually been copied to a whole bunch of places: http://lxr.mozilla.org/seamonkey/search?string=Append%28kNullCh%29
(But EnumerateMediaTypes in nsCSSLoader.cpp probably doesn't need to handle quotes.)
Created attachment 147769 [details] [diff] [review] patch (checked in to trunk, 2004-07-17 12:03 -0700)
Comment on attachment 147769 [details] [diff] [review] patch (checked in to trunk, 2004-07-17 12:03 -0700) I may as well get this out of my tree.
Codesize on luna: libgkgfx.so Total: +24 (+24/+0) +24 (+24/+0) text (CODE) +24 (+24/+0) UNDEF:libgkgfx.so:text +22 nsFont::EnumerateFamilies(int (*)(nsString const&, int, void*), void*) const +2 .nosyms.text libgklayout.so Total: -197 (+213/-410) -197 (+213/-410) text (DATA) -197 (+213/-410) UNDEF:libgklayout.so:text +211 ValueIncludes(nsSubstring const&, nsSubstring const&, nsStringComparator const&) +2 .nosyms.text -410 ValueIncludes(nsString const&, nsString const&, nsStringComparator const&)
Handling escaped quotes is (to some extent) bug 280443.