clean up nsFont::EnumerateFamilies and ValueIncludes

ASSIGNED
Assigned to

Status

()

Core
CSS Parsing and Computation
P2
normal
ASSIGNED
14 years ago
9 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

Trunk
mozilla1.8alpha1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [patch])

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

14 years ago
I want to clean up nsFont::EnumerateFamilies and ValueIncludes in
nsCSSStyleSheet.cpp.  They're similar.

Work in progress is in attachment 142321 [details] [diff] [review] on bug 235089.

In addition to what's there being done in both places, they need to handle
escaped quotes better, I think.
(Assignee)

Updated

14 years ago
Whiteboard: [patch]
(Assignee)

Comment 1

14 years ago
Created attachment 143991 [details] [diff] [review]
patch

updated patch, still only nsFont.cpp
(Assignee)

Updated

14 years ago
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → mozilla1.8alpha
(Assignee)

Comment 2

14 years ago
Created attachment 145058 [details] [diff] [review]
patch
Attachment #143991 - Attachment is obsolete: true
(Assignee)

Comment 3

14 years ago
The code in question has actually been copied to a whole bunch of places:

http://lxr.mozilla.org/seamonkey/search?string=Append%28kNullCh%29
(Assignee)

Comment 4

14 years ago
(But EnumerateMediaTypes in nsCSSLoader.cpp probably doesn't need to handle quotes.)
(Assignee)

Comment 5

14 years ago
Created attachment 147769 [details] [diff] [review]
patch (checked in to trunk, 2004-07-17 12:03 -0700)
Attachment #145058 - Attachment is obsolete: true
(Assignee)

Comment 6

14 years ago
Comment on attachment 147769 [details] [diff] [review]
patch (checked in to trunk, 2004-07-17 12:03 -0700)

I may as well get this out of my tree.
Attachment #147769 - Flags: superreview?(roc)
Attachment #147769 - Flags: review?(roc)
Attachment #147769 - Flags: superreview?(roc)
Attachment #147769 - Flags: superreview+
Attachment #147769 - Flags: review?(roc)
Attachment #147769 - Flags: review+
(Assignee)

Updated

13 years ago
Attachment #147769 - Attachment description: patch → patch (checked in to trunk, 2004-07-17 12:03 -0700)
(Assignee)

Comment 7

13 years ago
Codesize on luna:

  libgkgfx.so
  	Total:	        +24 (+24/+0)
  	        +24 (+24/+0)	text (CODE)
  		        +24 (+24/+0)	UNDEF:libgkgfx.so:text
  			        +22	nsFont::EnumerateFamilies(int (*)(nsString const&, int, void*),
void*) const
  			         +2	.nosyms.text
  
  libgklayout.so
  	Total:	       -197 (+213/-410)
  	       -197 (+213/-410)	text (DATA)
  		       -197 (+213/-410)	UNDEF:libgklayout.so:text
  			       +211	ValueIncludes(nsSubstring const&, nsSubstring const&,
nsStringComparator const&)
  			         +2	.nosyms.text
  			       -410	ValueIncludes(nsString const&, nsString const&,
nsStringComparator const&)
(Assignee)

Comment 8

11 years ago
Handling escaped quotes is (to some extent) bug 280443.
(Assignee)

Updated

10 years ago
QA Contact: ian → style-system
You need to log in before you can comment on or make changes to this bug.