clean up nsFont::EnumerateFamilies and ValueIncludes

ASSIGNED
Assigned to

Status

()

P3
normal
ASSIGNED
15 years ago
a month ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

Trunk
mozilla1.8alpha1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [patch])

Attachments

(1 attachment, 2 obsolete attachments)

I want to clean up nsFont::EnumerateFamilies and ValueIncludes in
nsCSSStyleSheet.cpp.  They're similar.

Work in progress is in attachment 142321 [details] [diff] [review] on bug 235089.

In addition to what's there being done in both places, they need to handle
escaped quotes better, I think.
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → mozilla1.8alpha
(But EnumerateMediaTypes in nsCSSLoader.cpp probably doesn't need to handle quotes.)
Comment on attachment 147769 [details] [diff] [review]
patch (checked in to trunk, 2004-07-17 12:03 -0700)

I may as well get this out of my tree.
Attachment #147769 - Flags: superreview?(roc)
Attachment #147769 - Flags: review?(roc)
Attachment #147769 - Flags: superreview?(roc)
Attachment #147769 - Flags: superreview+
Attachment #147769 - Flags: review?(roc)
Attachment #147769 - Flags: review+
Attachment #147769 - Attachment description: patch → patch (checked in to trunk, 2004-07-17 12:03 -0700)
Codesize on luna:

  libgkgfx.so
  	Total:	        +24 (+24/+0)
  	        +24 (+24/+0)	text (CODE)
  		        +24 (+24/+0)	UNDEF:libgkgfx.so:text
  			        +22	nsFont::EnumerateFamilies(int (*)(nsString const&, int, void*),
void*) const
  			         +2	.nosyms.text
  
  libgklayout.so
  	Total:	       -197 (+213/-410)
  	       -197 (+213/-410)	text (DATA)
  		       -197 (+213/-410)	UNDEF:libgklayout.so:text
  			       +211	ValueIncludes(nsSubstring const&, nsSubstring const&,
nsStringComparator const&)
  			         +2	.nosyms.text
  			       -410	ValueIncludes(nsString const&, nsString const&,
nsStringComparator const&)
Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information
Priority: P2 → P3
You need to log in before you can comment on or make changes to this bug.