Closed
Bug 236140
Opened 21 years ago
Closed 19 years ago
profile manager "conclusion" sheet doesn't fit - horizontal scrollbar
Categories
(SeaMonkey :: Startup & Profiles, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey1.0beta
People
(Reporter: asa, Assigned: stefanh)
Details
(Keywords: fixed1.8, Whiteboard: mac ui clean-up)
Attachments
(1 file)
1.00 KB,
patch
|
asaf
:
review+
neil
:
superreview+
mtschrep
:
approval1.8b5+
|
Details | Diff | Splinter Review |
On Mac OS X, the profile manager gets a horizontal scrollbar on the "conclusion"
sheet. I suspect the aqua buttons for "choose folder..." "use default folder"
and "region selection..." are the reason for the wide sheet.
Reporter | ||
Comment 1•21 years ago
|
||
Tested with 2004-03-01 SeaMonkey build on OS X 10.3 (Jaguar).
In case it wasn't clear, I'm talking about the final page of the "create
profile" wizard, accessible from the profile manager.
Reporter | ||
Updated•21 years ago
|
Whiteboard: mac ui clean-up
Updated•20 years ago
|
Product: Browser → Seamonkey
Assignee | ||
Comment 2•19 years ago
|
||
I still see this on branch and trunk. This is something we should fix before the
release...
Assignee | ||
Comment 3•19 years ago
|
||
OK, so the width of the sheet is currently set to 45em in
createProfileWizard.dtd. Now, there are three buttons: "Choose Folder...", "Use
Default Folder" and "Region Selection..."
If we change "Region Selection..." to "Select Region..." and increase the width
with 1em to 46em the sheet fits for me (Mac OS 10.3.9, Classic skin).
Kairo, what do you think?
Assignee | ||
Comment 4•19 years ago
|
||
> If we change "Region Selection..." to "Select Region..." and increase the width
> with 1em to 46em the sheet fits for me (Mac OS 10.3.9, Classic skin).
Actually, we don't gain much by changing the button label. The sheet fits
without changing the label if the width is set to 47em :)
Assignee | ||
Comment 5•19 years ago
|
||
OK, this patch will increase the width of the sheet with 2 em.
Assignee | ||
Updated•19 years ago
|
Severity: normal → minor
Target Milestone: --- → Seamonkey1.0alpha
Updated•19 years ago
|
Attachment #195537 -
Flags: review?(bugs.mano) → review+
Assignee | ||
Updated•19 years ago
|
Attachment #195537 -
Flags: superreview?(neil.parkwaycc.co.uk)
Assignee | ||
Updated•19 years ago
|
Target Milestone: Seamonkey1.0alpha → Seamonkey1.0beta
Assignee | ||
Comment 6•19 years ago
|
||
Comment on attachment 195537 [details] [diff] [review]
One-liner, increase width with 2em (Checked into branch and trunk)
btw, tested this with 640x480, and the sheet fits.
Comment 7•19 years ago
|
||
Comment on attachment 195537 [details] [diff] [review]
One-liner, increase width with 2em (Checked into branch and trunk)
Until someone implements width units in XUL I guess this will have to do :-/
Attachment #195537 -
Flags: superreview?(neil.parkwaycc.co.uk) → superreview+
Assignee | ||
Comment 8•19 years ago
|
||
Comment on attachment 195537 [details] [diff] [review]
One-liner, increase width with 2em (Checked into branch and trunk)
Low-risk, SeaMonkey mac ui polish.
Attachment #195537 -
Flags: approval1.8b5?
Comment 9•19 years ago
|
||
Comment on attachment 195537 [details] [diff] [review]
One-liner, increase width with 2em (Checked into branch and trunk)
Approved for 1.8b5 per bug meeting
Attachment #195537 -
Flags: approval1.8b5? → approval1.8b5+
Comment 10•19 years ago
|
||
Comment on attachment 195537 [details] [diff] [review]
One-liner, increase width with 2em (Checked into branch and trunk)
Checking in (trunk)
createProfileWizard.dtd; new revision: 1.11; previous revision: 1.10
done
Attachment #195537 -
Attachment description: One-liner, increase width with 2em → One-liner, increase width with 2em (Checked into trunk)
Comment 11•19 years ago
|
||
Comment on attachment 195537 [details] [diff] [review]
One-liner, increase width with 2em (Checked into branch and trunk)
Checking in (branch)
createProfileWizard.dtd; new revision: 1.10.58.1; previous revision: 1.10
done
Attachment #195537 -
Attachment description: One-liner, increase width with 2em (Checked into trunk) → One-liner, increase width with 2em (Checked into branch and trunk)
Assignee | ||
Comment 12•19 years ago
|
||
--> Fixed
Comment 13•19 years ago
|
||
As this shows up in my bonsai queries, let me sign this off as non-l10n.
This is just a size change, and seamonkey only, if a localizer starts reading the
bug bottom up. (Like I did, sorry for the bug spam)
You need to log in
before you can comment on or make changes to this bug.
Description
•