The default bug view has changed. See this FAQ.

profile manager "conclusion" sheet doesn't fit - horizontal scrollbar

RESOLVED FIXED in seamonkey1.0beta

Status

SeaMonkey
Startup & Profiles
--
minor
RESOLVED FIXED
13 years ago
12 years ago

People

(Reporter: asa, Assigned: stefanh)

Tracking

({fixed1.8})

Trunk
seamonkey1.0beta
PowerPC
Mac OS X
fixed1.8

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: mac ui clean-up)

Attachments

(1 attachment)

(Reporter)

Description

13 years ago
On Mac OS X, the profile manager gets a horizontal scrollbar on the "conclusion"
sheet. I suspect the aqua buttons for "choose folder..." "use default folder"
and "region selection..." are the reason for the wide sheet.
(Reporter)

Comment 1

13 years ago
Tested with 2004-03-01 SeaMonkey build on OS X 10.3 (Jaguar). 

In case it wasn't clear, I'm talking about the final page of the "create
profile" wizard, accessible from the profile manager. 
(Reporter)

Updated

13 years ago
Whiteboard: mac ui clean-up
Product: Browser → Seamonkey
(Assignee)

Comment 2

12 years ago
I still see this on branch and trunk. This is something we should fix before the
release...
(Assignee)

Comment 3

12 years ago
OK, so the width of the sheet is currently set to 45em in
createProfileWizard.dtd. Now, there are three buttons: "Choose Folder...", "Use
Default Folder" and "Region Selection..."

If we change "Region Selection..." to "Select Region..." and increase the width
with 1em to 46em the sheet fits for me (Mac OS 10.3.9, Classic skin).

Kairo, what do you think?
(Assignee)

Comment 4

12 years ago
 
> If we change "Region Selection..." to "Select Region..." and increase the width
> with 1em to 46em the sheet fits for me (Mac OS 10.3.9, Classic skin).

Actually, we don't gain much by changing the button label. The sheet fits
without changing the label if the width is set to 47em :)



(Assignee)

Comment 5

12 years ago
Created attachment 195537 [details] [diff] [review]
One-liner, increase width with 2em (Checked into branch and trunk)

OK, this patch will increase the width of the sheet with 2 em.
Assignee: nobody → stefan_h
Status: NEW → ASSIGNED
Attachment #195537 - Flags: review?(bugs.mano)
(Assignee)

Updated

12 years ago
Severity: normal → minor
Target Milestone: --- → Seamonkey1.0alpha
Attachment #195537 - Flags: review?(bugs.mano) → review+
(Assignee)

Updated

12 years ago
Attachment #195537 - Flags: superreview?(neil.parkwaycc.co.uk)
(Assignee)

Updated

12 years ago
Target Milestone: Seamonkey1.0alpha → Seamonkey1.0beta
(Assignee)

Comment 6

12 years ago
Comment on attachment 195537 [details] [diff] [review]
One-liner, increase width with 2em (Checked into branch and trunk)

btw, tested this with 640x480, and the sheet fits.

Comment 7

12 years ago
Comment on attachment 195537 [details] [diff] [review]
One-liner, increase width with 2em (Checked into branch and trunk)

Until someone implements width units in XUL I guess this will have to do :-/
Attachment #195537 - Flags: superreview?(neil.parkwaycc.co.uk) → superreview+
(Assignee)

Comment 8

12 years ago
Comment on attachment 195537 [details] [diff] [review]
One-liner, increase width with 2em (Checked into branch and trunk)

Low-risk, SeaMonkey mac ui polish.
Attachment #195537 - Flags: approval1.8b5?

Comment 9

12 years ago
Comment on attachment 195537 [details] [diff] [review]
One-liner, increase width with 2em (Checked into branch and trunk)

Approved for 1.8b5 per bug meeting
Attachment #195537 - Flags: approval1.8b5? → approval1.8b5+

Comment 10

12 years ago
Comment on attachment 195537 [details] [diff] [review]
One-liner, increase width with 2em (Checked into branch and trunk)

Checking in (trunk)
createProfileWizard.dtd; new revision: 1.11; previous revision: 1.10
done
Attachment #195537 - Attachment description: One-liner, increase width with 2em → One-liner, increase width with 2em (Checked into trunk)

Comment 11

12 years ago
Comment on attachment 195537 [details] [diff] [review]
One-liner, increase width with 2em (Checked into branch and trunk)

Checking in (branch)
createProfileWizard.dtd; new revision: 1.10.58.1; previous revision: 1.10
done
Attachment #195537 - Attachment description: One-liner, increase width with 2em (Checked into trunk) → One-liner, increase width with 2em (Checked into branch and trunk)
(Assignee)

Comment 12

12 years ago
--> Fixed
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Keywords: fixed1.8
Resolution: --- → FIXED

Comment 13

12 years ago
As this shows up in my bonsai queries, let me sign this off as non-l10n.
This is just a size change, and seamonkey only, if a localizer starts reading the 
bug bottom up. (Like I did, sorry for the bug spam)
You need to log in before you can comment on or make changes to this bug.