Closed Bug 236294 Opened 20 years ago Closed 20 years ago

installer exits before user sees CRC Failed dialog

Categories

(SeaMonkey :: Installer, defect)

Product:
SeaMonkey
Component:
Installer
Platform:
All
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: ajschult784, Assigned: ajschult784)

Details

Attachments

(2 files)

ShowCRCFailedDlg => ErrorHandler
8.43 KB, patch
dveditz
: review+
dveditz
: superreview+
Details | Diff | Splinter Review
patch merged to current CVS (for checkin)
7.37 KB, patch
Details | Diff | Splinter Review 
The installer puts up the CRC Failed dialog and immeadiately exits.  It should
(of course) wait for the user to read the message and click "ok".

On another level, the dialog is overkill and it can be replaced with
ErrorHandler without any loss of function.

    
    

    
  
Comment on attachment 142818 [details] [diff] [review]
ShowCRCFailedDlg => ErrorHandler

this patch also includes the one from bug 235139 as the installer would still
simply exit without it.

        Attachment #142818 -
        Flags: review?(bsmedberg)

    
    

    
  
Comment on attachment 142818 [details] [diff] [review]
ShowCRCFailedDlg => ErrorHandler

I cannot review this

        Attachment #142818 -
        Flags: review?(bsmedberg) → review?(dveditz+bmo)

    
    

    
  
Comment on attachment 142818 [details] [diff] [review]
ShowCRCFailedDlg => ErrorHandler

>Index: nsXInstaller.cpp

bug 235139 is fixed, so this portion of the patch has already landed.

    
    

    
  
Comment on attachment 142818 [details] [diff] [review]
ShowCRCFailedDlg => ErrorHandler

r/sr=dveditz

        Attachment #142818 -
        Flags: superreview+

        Attachment #142818 -
        Flags: review?(dveditz)

        Attachment #142818 -
        Flags: review+

    
    

    
  
checked in by timeless
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Summary: installer exits before user sees CRC Failed dialog → installer exits before user sees CRC Failed dialog
Product: Browser → Seamonkey

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: