Build Identifier entry on guided bugreport form is broken

RESOLVED FIXED in Bugzilla 2.18



16 years ago
7 years ago


(Reporter: ali, Assigned: gerv)


Bugzilla 2.18
Dependency tree / graph
Bug Flags:
approval +




(1 attachment)

On the guided bugreport form there is a field called "Build Identifier (User
Agent)". It is prefilled with the user's browser's UA. The user can edit this
field to whatever he/she wants.

Prior to the upgrade, when a bug was generated from the
guided form, the field "Build Identifier" in comment 0 would be set to the
sniffed actual browser UA that submitted the bugreport (which matches the
prefilled value on the guided form). The field "User-Agent" in comment 0 would
be set to whatever value the user had in that field when he/she submitted the
bug (usually the default, but sometimes different).

After the upgrade, the "Build Identifier" in comment 0 always matches the value
that was in the "Build Identifier (User Agent)" on the guided form at the time
of bug submittal (not necessarily the actual sniffed UA). The "User-Agent" field
in comment 0 is now always blank. This behaviour is broken. See bug 236287 for
an example of this.

We should restore functionality to what it was before the upgrade.
Posted patch Patch v.1Splinter Review
We obviously broke this without noticing.

Comment on attachment 142823 [details] [diff] [review]
Patch v.1

Dave: can we get this in? The reporter is right - it needs fixing on b.m.o. as
soon as we can.

Attachment #142823 - Flags: review?(justdave)
Whiteboard: [wanted for 2.17.7]?
2.17.7 has already been tagged and tarballed.

I'll apply it to b.m.o though.
Attachment #142823 - Flags: review?(justdave) → review+
Flags: approval+
Whiteboard: [wanted for 2.17.7]? → [applied to b.m.o]
I just want to correct my initial report (comment 0), in which in my description
of the behaviour prior to the upgrade, I mixed up what the "Build Identifier"
and "User-Agent" fields would show.

In fact, prior to the upgrade, the "User-Agent" field would contain the sniffed
UA regardless of what was entered in the guided form, and the "Build Identifier"
field would contain whatever text was entered in the guided form.

Looking at your patch, it seems like you guys picked up on this already, but I
just wanted to comment anyway for completeness' sake.
The fix appears to have worked on See bug 236382 for a
test. I'm not marking as FIXED because I'm not sure what you guys want to do
about the Bugzilla product itself and if its been checked into CVS there.

Checking in template/en/default/bug/create/comment-guided.txt.tmpl;
 <--  comment-guided.txt.tmpl
new revision: 1.2; previous revision: 1.1

Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → Bugzilla 2.18
Whiteboard: [applied to b.m.o]
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.