All WIN32 GDI calls should check return code

RESOLVED WONTFIX

Status

defect
RESOLVED WONTFIX
15 years ago
5 years ago

People

(Reporter: d_king, Unassigned)

Tracking

Trunk
x86
Windows XP
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Reporter

Description

15 years ago
This is to track code that doesn't properly (if at all) check the return code
from GDI function calls.

This is marked as blocking Bug #204374, but that may change as time goes on.
Reporter

Comment 1

15 years ago
Most code is good, but I've found some code in nsImageWin and ControlSite that
needs some minor fixes. Still looking and fixing.....this will take a while.

Comment 2

15 years ago
I also checked a few days ago nsImageWin for missing return code checks. (The
most are for memory allocation.) I missed to fill a bug for this errors, so I
think this bug is a good place to take a look on them:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/gfx/src/windows/nsImageWin.cpp&rev=3.128&root=/cvsroot&mark=139,144,165,205,210,217,882,890,1453,1517,1560,1606,1623,1674,1679,1922,1954#130
Reporter

Comment 3

15 years ago
Daniel, thanks for that list. I'd come across one in nsImageWin, but your link
will help with the rest of them.
Reporter

Comment 4

15 years ago
Posted patch Example patchSplinter Review
This is an example of what I'm working on for this bug. This patch isn't
complete, it doesn't even fix all of nsImageWin.cpp, never mind all the other
program files.
Reporter

Updated

15 years ago
Assignee: dgk → nobody
An unloved (draft) patch?  Is the idea obsolete with the eventual passing of support for w98?

(In reply to comment #0)
> This is marked as blocking Bug #204374, but that may change as time goes on.

204374 got duped to bug 205893. should this bug now block 205893?  What about bug 284978?
Reporter

Comment 6

13 years ago
The idea isn't obsolete as the GDI is still used in WinXP SP2, and checking return codes is just good practise.
Product: Core → Core Graveyard
This bug has been buried in the graveyard and has not been updated in over 5 years. It is probably safe to assume that it will never be fixed, so resolving as WONTFIX.

[Mass-change filter: graveyard-wontfix-2014-09-24]
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.