Closed Bug 236438 Opened 18 years ago Closed 18 years ago

Wrong x/y values sent on image button (input[type=image])

Categories

(Core :: Layout: Form Controls, defect, P1)

defect

Tracking

()

VERIFIED FIXED

People

(Reporter: harunaga, Assigned: roc)

References

()

Details

(Keywords: regression)

Attachments

(1 file)

Recent build sends wrong x/y coordinate values on image button
(input[type=image]).

Steps:
1. Load http://maps.yahoo.com/maps_result?ed=M7tNO.p_0TqT&csz=new+york&country=us
2. Click around "Broadway" inside the map.

Result:
"Atlantic Ocean".

Confirmed with 2004022909/WinNT and 2004030205/Mac.
1.6 doesn't have this problem.
regression.

See also testcase in the URL above.
(Save the testcase to disk, and open)
It seems that Mozilla sends coordinates inside the window,
instead of inside the image...
2004022805 has no problem, 2004022905 is broken.
Backing out bug 53966 fixes this.
Assignee: form-submission → roc
Component: HTML: Form Submission → Layout: Form Controls
Depends on: 53966
eek
Priority: -- → P2
I bet adding a call to nsImageFrame::TranslateEventCoords at
http://lxr.mozilla.org/seamonkey/source/layout/html/forms/src/nsImageControlFrame.cpp#266
fixes this.
Attached patch fixSplinter Review
Indeed, you're right.
Mm... and the old code was buggy with borders too, eh?  ;)
Comment on attachment 142972 [details] [diff] [review]
fix

r+sr=bzbarsky
Attachment #142972 - Flags: superreview+
Attachment #142972 - Flags: review+
Attachment #142972 - Flags: superreview?(bzbarsky)
Attachment #142972 - Flags: review?(bzbarsky)
Attachment #142972 - Flags: superreview?(bzbarsky)
Attachment #142972 - Flags: review?(bzbarsky)
Checked in.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Verified fixed, 2004-03-06-09 trunk Linux.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.