236674 - Separator appearance should be that of a separator in bookmark manager.

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, enhancement)

Description

[Jasper]

As it stands the appearance of a separator in the bookmark manager is just like
that of a bookmark. I think we should go for a more functional appearance.

I like the way Firefox makes them look but know that would be rather hard to do
in Camino.

Comment 1

[Jasper]

Attachment: An image to show how it might look.

I think that removing the bookmark icon from the separator appearance and
giving it a new title "---------" would make it look and feel more like a
separator.

Comment 2

[Greg K.]

Why use text dashes? Surely we can draw a real separator there.

Comment 3

[Jasper]

Sure we could, it's just that that would take a whole lot more coding.

Comment 4

[Steve Ruge]

(In reply to comment #3)
> Sure we could, it's just that that would take a whole lot more coding.

This should be fixed as a cosmetic fix when the bookmarks are overhauled. I'd
hope that as Mac users we'd expect someting a bit more better looking than -----
so I agree with Greg's comments about using a "real" seperator.

Comment 5

[Jasper]

The idea was to have a better looking separator untill somebody actually took
the time to create a real one. What we do now is way more bad then having ---.

I agree the sperator should look good.

Comment 6

[Richard Briscoe]

Just what is supposed to "look good"?

I thought that the idea was to make something that was visually obvious that there was a separation 
between different groups of bookmarks.  A line of some sort does this very simply and is sufficiently 
obvious that it passes the "Little Abner Rule" (as any fool can plainly see).  

The present "<Menu Spacer>" is essentially useless as it does not stand out from the bookmarks at all.

Please take a look at the implementation in Mozilla or Firefox to see the difference.

Comment 7

[Jon Hicks]

Attachment: Screenshot of Omniweb's Bookmark Separator

I like Omniweb's approach, which is just a plain solid line for the width of the 'label' column, rather than Firefox's dotted line.

Comment 8

[Stuart Morgan]

Attachment: fix

Fix. It turns out (coincidentally, since I hadn't looked at these screenshots) to look about like comment 7.

Comment 9

[Stuart Morgan]

Attachment: icon

The new .tif for the separator.

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Trunk project patch

Comment 11

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Branch project patch

Looks good, Stuart!

Comment 12

[Nick Kreeger]

Comment on attachment 241714 [details] [diff] [review]
fix

Looks good to me.

Comment 13

[Mike Pinkerton (not reading bugmail)]

+      float fullWidth = [tableColumn width] - 19 - [outlineView indentationPerLevel]*[outlineView levelForItem:item];
+      NSSize imageSize = [mSeparatorImage size];
+      imageSize.width = (fullWidth > 16) ? fullWidth : 16;

any way we can get these magic #s into constants? 

Comment 14

[Stuart Morgan]

Attachment: a less magical version

Comment 15

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 241943 [details] [diff] [review]
a less magical version

sr=pink

Comment 16

[froodian (Ian Leue)]

Checked in on 1.8branch and trunk.