Separator appearance should be that of a separator in bookmark manager.



Camino Graveyard
14 years ago
11 years ago


(Reporter: Jasper, Assigned: Stuart Morgan)


({fixed1.8.1.1, polish})

Mac OS X
fixed1.8.1.1, polish



(6 attachments, 1 obsolete attachment)



14 years ago
As it stands the appearance of a separator in the bookmark manager is just like
that of a bookmark. I think we should go for a more functional appearance.

I like the way Firefox makes them look but know that would be rather hard to do
in Camino.

Comment 1

14 years ago
Created attachment 143583 [details]
An image to show how it might look.

I think that removing the bookmark icon from the separator appearance and
giving it a new title "---------" would make it look and feel more like a

Comment 2

14 years ago
Why use text dashes? Surely we can draw a real separator there.

Comment 3

14 years ago
Sure we could, it's just that that would take a whole lot more coding.
Target Milestone: --- → Camino1.1

Comment 4

13 years ago
(In reply to comment #3)
> Sure we could, it's just that that would take a whole lot more coding.

This should be fixed as a cosmetic fix when the bookmarks are overhauled. I'd
hope that as Mac users we'd expect someting a bit more better looking than -----
so I agree with Greg's comments about using a "real" seperator.

Comment 5

13 years ago
The idea was to have a better looking separator untill somebody actually took
the time to create a real one. What we do now is way more bad then having ---.

I agree the sperator should look good.

Comment 6

13 years ago
Just what is supposed to "look good"?

I thought that the idea was to make something that was visually obvious that there was a separation 
between different groups of bookmarks.  A line of some sort does this very simply and is sufficiently 
obvious that it passes the "Little Abner Rule" (as any fool can plainly see).  

The present "<Menu Spacer>" is essentially useless as it does not stand out from the bookmarks at all.

Please take a look at the implementation in Mozilla or Firefox to see the difference.
Assignee: mikepinkerton → nobody
Keywords: polish
OS: Mac OS X 10.2 → Mac OS X 10.3
QA Contact: bookmarks
Target Milestone: Camino1.1 → Camino2.0

Comment 7

11 years ago
Created attachment 239343 [details]
Screenshot of Omniweb's Bookmark Separator 

I like Omniweb's approach, which is just a plain solid line for the width of the 'label' column, rather than Firefox's dotted line.

Comment 8

11 years ago
Created attachment 241714 [details] [diff] [review]

Fix. It turns out (coincidentally, since I hadn't looked at these screenshots) to look about like comment 7.
Assignee: nobody → stuart.morgan
Attachment #241714 - Flags: review?

Comment 9

11 years ago
Created attachment 241715 [details]

The new .tif for the separator.
Attachment #241715 - Attachment mime type: application/octet-stream → image/tiff
Created attachment 241789 [details] [diff] [review]
Trunk project patch
Created attachment 241791 [details] [diff] [review]
Branch project patch

Looks good, Stuart!


11 years ago
Attachment #241714 - Flags: review? → review?(nick.kreeger)

Comment 12

11 years ago
Comment on attachment 241714 [details] [diff] [review]

Looks good to me.
Attachment #241714 - Flags: review?(nick.kreeger) → review+


11 years ago
Attachment #241714 - Flags: superreview?(mikepinkerton)
+      float fullWidth = [tableColumn width] - 19 - [outlineView indentationPerLevel]*[outlineView levelForItem:item];
+      NSSize imageSize = [mSeparatorImage size];
+      imageSize.width = (fullWidth > 16) ? fullWidth : 16;

any way we can get these magic #s into constants? 

Comment 14

11 years ago
Created attachment 241943 [details] [diff] [review]
a less magical version
Attachment #241714 - Attachment is obsolete: true
Attachment #241943 - Flags: superreview?(mikepinkerton)
Attachment #241714 - Flags: superreview?(mikepinkerton)
Comment on attachment 241943 [details] [diff] [review]
a less magical version

Attachment #241943 - Flags: superreview?(mikepinkerton) → superreview+

Comment 16

11 years ago
Checked in on 1.8branch and trunk.
Last Resolved: 11 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED


11 years ago
Keywords: fixed1.8.1.1


11 years ago
Keywords: fixed1.8.1
You need to log in before you can comment on or make changes to this bug.