236864 - Control+Shift+click on bookmark should open a background tab

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Ben Basson]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040206 Firefox/0.8
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040206 Firefox/0.8

Control + Shift + Clicking on a bookmark from the drop down menu or the sidebar
loads the bookmark in a new window. This is inconsistent with the key modifiers
for clicking on hyperlinks within documents.

Ctrl + Shift + Click on hyperlink = New foreground/active tab
Ctrl + Shift + Click on bookmark = New window

Shift + Click on hyperlink = New window
Shift + Click on bookmark = New window 

Ctrl + Click on hyperlink = New background tab
Ctrl + Click on bookmark = New background tab

This behaviour should be changed for consistency, and because there appears to
be no other way to launch a bookmark in an active/foreground tab.

Reproducible: Always
Steps to Reproduce:
1. Select "Bookmarks" from the Firefox menu bar.
2. Hold down Ctrl and Shift, click on a bookmark.
Actual Results:  
The bookmark is launched in a new window.

Expected Results:  
Launched the bookmark in an active tab, as per the document hyperlink behaviour.

Comment 1

[Ben Basson]

Interestingly enough, I now have a different set of responses for my keybinds
when clicking bookmarks... however, they are still inconsistent with my keybind
behavior for hyperlinks. I can only assume that an extension was modifying them
in the first case, but with a new profile, I still get the wrong results:

Control + Shift + Click (Hyperlink) = New Foreground Tab
Control + Shift + Click (Bookmark) = New Window

Shift + Click (Hyperlink) = New Window
Shift + Click (Bookmark) = New Window

Control + Click (Hyperlink) = New Background Tab
Control + Click (Bookmark) = New Foreground Tab

Comment 2

[Mike Connor [:mconnor]]

> Control + Click (Hyperlink) = New Background Tab 
> Control + Click (Bookmark) = New Foreground Tab
seems inconsistent at first, but its intended behaviour that I really like once
I got used to it (over a year ago now), that's another bug altogether.

http://lxr.mozilla.org/mozilla/source/browser/components/bookmarks/content/bookmarks.js#1367
doesn't handle Ctrl-Shift any different than Shift

now, really what SHOULD happen here is that it opens in a background tab, being
that Shift is supposed to invert the behaviour of Ctrl-based shortcuts.  Plus,
Ctrl-Click opens in the foreground by default.

pch, do we want Ctrl-Shift-Click to be foreground or background?  I'm thinking
background makes more sense, but that'll be a bit more work since we current
just return "tab" or "window" with no ability to specify foreground/background.

Comment 3

[Ben Basson]

It really should invert the behaviour as you say, so that bookmarks can actually
 be opened in the background.

TBE can specify foreground and background tabs for various events, so I would
have thought that the amount of work required wouldn't be extensive (not that I
know anything).

Comment 4

[Ben Basson]

It's not a serious bug, but for the sake of consistency (for a good 1.0 release)
this should be fixed IMO. Nominating as blocker for 1.0, but feel free to bitch
at me if this isn't appropriate.

Comment 5

[Jesse Ruderman]

Reversing summary based on comment 2 and comment 3.

I have a patch, which I will attach to bug 246719.

Comment 6

[Jesse Ruderman]

Fix checked in 2004-06-23 15:54 PST.

Comment 7

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change