Last Comment Bug 237078 - Remove table background quirk
: Remove table background quirk
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Layout: Tables (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: fantasai
:
Mentors:
: 239207 (view as bug list)
Depends on: 4510 240854
Blocks:
  Show dependency treegraph
 
Reported: 2004-03-10 17:45 PST by fantasai
Modified: 2004-04-18 12:13 PDT (History)
7 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (17.83 KB, patch)
2004-04-15 18:53 PDT, fantasai
bernd_mozilla: review+
dbaron: superreview+
Details | Diff | Splinter Review
diff (ignoring whitespace) (16.86 KB, text/plain)
2004-04-15 18:54 PDT, fantasai
no flags Details
new patch (17.83 KB, patch)
2004-04-17 12:13 PDT, fantasai
no flags Details | Diff | Splinter Review
new diff (ignoring whitespace) (20.39 KB, text/plain)
2004-04-17 12:16 PDT, fantasai
no flags Details

Description fantasai 2004-03-10 17:45:14 PST
Just to reword the summary,

  Remove quirky table background painting for 1.8a and back out the change in a
  later release if it causes problems.
Comment 1 Boris Zbarsky [:bz] 2004-03-30 18:11:03 PST
*** Bug 239207 has been marked as a duplicate of this bug. ***
Comment 2 fantasai 2004-04-15 18:53:38 PDT
Created attachment 146239 [details] [diff] [review]
patch
Comment 3 fantasai 2004-04-15 18:54:29 PDT
Created attachment 146240 [details]
diff (ignoring whitespace)
Comment 4 David Baron :dbaron: ⌚️UTC+2 (mostly busy through August 4; review requests must explain patch) 2004-04-16 14:39:08 PDT
Comment on attachment 146239 [details] [diff] [review]
patch

sr=dbaron, although I think it would be slightly cleaner to make aDeflate an
|const nsMargin&| and change nsTableFrame::Paint so the
      nsMargin deflate(0,0,0,0);
and the call to PaintTable were outside the quirks mode if/else (with no else
at all anymore).
Comment 5 Bernd 2004-04-17 11:19:01 PDT
Comment on attachment 146239 [details] [diff] [review]
patch

with those changes that david asked for
Comment 6 fantasai 2004-04-17 12:13:11 PDT
Created attachment 146358 [details] [diff] [review]
new patch
Comment 7 fantasai 2004-04-17 12:16:18 PDT
Created attachment 146359 [details]
new diff (ignoring whitespace)
Comment 8 Bernd 2004-04-18 05:23:19 PDT
It would be cool if attachment 146358 [details] [diff] [review] wouldn't crash the regression tests at
layout/html/tests/dom/deleteCol3.html
Comment 9 Bernd 2004-04-18 12:13:25 PDT
fix checked in

Note You need to log in before you can comment on or make changes to this bug.