Remove table background quirk

RESOLVED FIXED

Status

()

Core
Layout: Tables
RESOLVED FIXED
14 years ago
13 years ago

People

(Reporter: fantasai, Assigned: fantasai)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

14 years ago
Just to reword the summary,

  Remove quirky table background painting for 1.8a and back out the change in a
  later release if it causes problems.
(Assignee)

Updated

14 years ago
Depends on: 4510
*** Bug 239207 has been marked as a duplicate of this bug. ***
(Assignee)

Comment 2

13 years ago
Created attachment 146239 [details] [diff] [review]
patch
(Assignee)

Comment 3

13 years ago
Created attachment 146240 [details]
diff (ignoring whitespace)
(Assignee)

Updated

13 years ago
Attachment #146239 - Flags: superreview?(dbaron)
Attachment #146239 - Flags: review?(bernd.mielke)
Comment on attachment 146239 [details] [diff] [review]
patch

sr=dbaron, although I think it would be slightly cleaner to make aDeflate an
|const nsMargin&| and change nsTableFrame::Paint so the
      nsMargin deflate(0,0,0,0);
and the call to PaintTable were outside the quirks mode if/else (with no else
at all anymore).
Attachment #146239 - Flags: superreview?(dbaron) → superreview+
(Assignee)

Updated

13 years ago
Attachment #146239 - Flags: review?(bernd.mielke) → review?(bernd_mozilla)

Comment 5

13 years ago
Comment on attachment 146239 [details] [diff] [review]
patch

with those changes that david asked for
Attachment #146239 - Flags: review?(bernd_mozilla) → review+
(Assignee)

Comment 6

13 years ago
Created attachment 146358 [details] [diff] [review]
new patch
Attachment #146239 - Attachment is obsolete: true
(Assignee)

Comment 7

13 years ago
Created attachment 146359 [details]
new diff (ignoring whitespace)
(Assignee)

Updated

13 years ago
Attachment #146240 - Attachment is obsolete: true

Comment 8

13 years ago
It would be cool if attachment 146358 [details] [diff] [review] wouldn't crash the regression tests at
layout/html/tests/dom/deleteCol3.html

Updated

13 years ago
Depends on: 240854

Comment 9

13 years ago
fix checked in
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.