Closed Bug 237176 Opened 16 years ago Closed 16 years ago

full-text results should show relevance column

Categories

(Bugzilla :: Query/Bug List, enhancement)

x86
Windows XP
enhancement
Not set

Tracking

()

RESOLVED FIXED
Bugzilla 2.18

People

(Reporter: asa, Assigned: myk)

Details

Attachments

(1 file)

It would be nice if results from the fulltext searching would display relevance
as a column.
This patch makes it possible for a user to add the relevance column to both the
"order" and the "columnlist" parameters to sort by relevance and to add
relevance to the search results, respectively.	As a side effect, it removes
the restriction that full text searches be sorted by relevance, although they
remain sorted that way by default.

As with bug 234797, there's intentionally no UI here.  This is a power user
feature and should remain that way until we can figure out the right way to
make this available to the masses (in particular, the relevance values need to
be represented intelligibly).
Comment on attachment 143657 [details] [diff] [review]
patch v1: implements feature

Dave, can you peruse this patch?  Much of the changes are moving around the
code that handles the "order" parameter.  Currently it assumes a custom order
if the parameter has a dot in it, but "relevance" has no dot, so the current
code can't handle that.

My revision checks for the standard values (Bug Number, Last Changed, etc.)
first, then assumes/parses/validates a custom value.

You can check out what this does at the following URL:

http://bugzilla.mozilla.org/buglist-bm.cgi?query_format=specific&bug_status=__a
ll__&product=Bugzilla&content=foo+bar+baz&columnlist=relevance,product,componen
t,assigned_to,bug_priority,severity,short_desc&order=relevance%20desc

(Note that the version being tested in the URL doesn't contain the LIMIT
clause, although this patch does contain that clause.)
Attachment #143657 - Flags: review?(justdave)
Comment on attachment 143657 [details] [diff] [review]
patch v1: implements feature

I like this.  To heck with the %::FORM access, they haven't fixed this file yet
anyway, they can change it all when they convert this one. :)
Attachment #143657 - Flags: review?(justdave) → review+
Flags: approval+
Target Milestone: --- → Bugzilla 2.18
Severity: normal → enhancement
Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.251; previous revision: 1.250
done
Checking in Bugzilla/Search.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search.pm,v  <--  Search.pm
new revision: 1.53; previous revision: 1.52
done
Checking in template/en/default/search/search-specific.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/search-specific.html.tmpl,v
 <--  search-specific.html.tmpl
new revision: 1.5; previous revision: 1.4
done
Checking in template/en/default/bug/create/create-guided.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/create-guided.html.tmpl,v
 <--  create-guided.html.tmpl
new revision: 1.18; previous revision: 1.17
done
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
/me sees comment 3 and wonders who exactly "they" should be
I bet you do. :)
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.