237185 - nsXPathNSResolver::LookupNamespaceURI needs to resolve xml

Status: RESOLVED FIXED

(Core :: XSLT, defect)

Description

[Peter Van der Beken [:peterv]]

See
http://www.w3.org/TR/2004/NOTE-DOM-Level-3-XPath-20040226/xpath.html#XPathEvaluator-createNSResolver
("also correctly resolving the implicit xml prefix.").

Comment 1

[Peter Van der Beken [:peterv]]

Attachment: Fix

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 143663 [details] [diff] [review]
Fix

+    if (aPrefix.Equals(NS_LITERAL_STRING("xml"))) {
+	 aResult = NS_LITERAL_STRING("http://www.w3.org/XML/1998/namespace");
+
+	 return NS_OK;
+    }
+
+    if (mNode) {
	 return mNode->LookupNamespaceURI(aPrefix, aResult);
+    }
+
     SetDOMStringToNull(aResult);
+
     return NS_OK;

While you're at it, wanna flip that around to return the real lookup result at
the end of the method and the make the null return be an early return, like the
other exception?

r+sr=jst

Comment 3

[Peter Van der Beken [:peterv]]

Comment on attachment 143663 [details] [diff] [review]
Fix

Small DOM correctness fix. Makes the xml prefix resolve to the right namespace
URI. This API is not used a lot, very low risk.

Comment 4

[chris hofmann]

Comment on attachment 143663 [details] [diff] [review]
Fix

a=chofmann for 1.7b