make xpistub interface description and implementation agree

RESOLVED FIXED

Status

Core Graveyard
Installer: XPInstall Engine
RESOLVED FIXED
14 years ago
2 years ago

People

(Reporter: Andrew Schultz, Assigned: Andrew Schultz)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

14 years ago
xpistub.h says that XPI_Init
1. takes parameters aProgramDir, startCB, progressCB and finalCB
2. aProgramDir: "...If NULL default will be used -- the location of the calling
executable."

in xpistub.c, XPI_Init
1. takes parameters aProgramDir, aLogName and progressCB
2. if aProgramDir is NULL, XPI_Init crashes
http://lxr.mozilla.org/mozilla/source/xpinstall/stub/xpistub.cpp#197

for #1, the interface description should be updated.
I'd like to actually implement #2 for use in bug 77365
(Assignee)

Comment 1

14 years ago
Created attachment 143871 [details] [diff] [review]
patch

cleanup xpistub.h and implement handling NULL aProgramDir parameter.
(Assignee)

Updated

14 years ago
Attachment #143871 - Flags: review?(bsmedberg)

Comment 2

14 years ago
Comment on attachment 143871 [details] [diff] [review]
patch

r=me
please remove the XP_MAC cruft in this file, while you're touching it (we no
longer support MacOS9).
Attachment #143871 - Flags: review?(bsmedberg) → review+
(Assignee)

Comment 3

14 years ago
Created attachment 144745 [details] [diff] [review]
patch + remove XP_MAC
Attachment #143871 - Attachment is obsolete: true
(Assignee)

Comment 4

14 years ago
Comment on attachment 144745 [details] [diff] [review]
patch + remove XP_MAC

this already has r=bsmedberg
Attachment #144745 - Flags: superreview?(dveditz+bmo)
Attachment #144745 - Flags: review+
Comment on attachment 144745 [details] [diff] [review]
patch + remove XP_MAC

Thanks!
sr=dveditz
Attachment #144745 - Flags: superreview?(dveditz) → superreview+
(Assignee)

Comment 6

14 years ago
Created attachment 146989 [details] [diff] [review]
patch merged to trunk (for checkin)
(Assignee)

Comment 7

14 years ago
checked in by timeless
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.