23759 - add "-z text" to DSO_LDOPTS for solaris/workshop

Status: RESOLVED WONTFIX

(SeaMonkey :: Build Config, defect, P3)

Description

[Dan Mosedale (:dmosedale, :dmose)]

By default, the solaris linker is willing to link non-PIC code into shared
libraries.  If someone has their LD_LIBRARY_PATH set in an unusual way, this can
cause errors that are subtle and difficult to track down.

Adding "-z text" to DSO_LDOPTS on solaris will instead cause the linker to abort
if it stumbles across non-PIC code while linking a shared library.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

This seems to cause problems with gcc.  Under investigation.

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

This currently breaks gcc builds, so it's not yet checked in.  Here's a link to
the libraries and linker documentation for Solaris:

http://docs.sun.com:80/ab2/coll.45.4/LLM/

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Turns out that gcc builds didn't have the -fPIC flag set when using gcc as the
assembler, and the machines that we were using had libg++ only installed
statically.  So plenty of non-PIC code was getting included, including the
xptcall assembly.  I'm gonna post a patch to configure.in that will both add "-z
text" and fix the assembler problem to mozilla-unix for comment, probably
tommorrow.

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Oh yeah, we were also using -G instead of -shared in the DSO_LDFLAGS on gcc as
well.  My patch will get that too.

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

In order to make this easier to get into the tree piecemeal, I've split this out
into three separate bugs.  This bug is now for WorkShop builds only, bug 35419
is for gcc builds, and bug 35418 is a prerequisite to the gcc fix.

Comment 6

[Chris Yeh]

mass re-assign of all bugs where i was listed as the qa contact

Comment 7

[Dan Mosedale (:dmosedale, :dmose)]

Reassigning Solaris-specific bugs to richb.

Comment 8

[Rich Burridge]

[richb - 6/1/00]
Reassigning bug to Sherry Shen.

Comment 9

[Rich Burridge]

Wrong bug. Sorry Sherry. Reassigning back to me.

Comment 10

[Rich Burridge]

Reassigning to Ed to do with as he wants.

Comment 11

[edburns]

I'll ask our RE person to look at this.

Comment 12

[edburns]

Hi Kevin,

This one looks pretty easy.  Please comment.

Thanks,

Ed

Comment 13

[cls]

Switching to using -shared instead of -G (bug 35419) apparently enabled -z text
as well.  This is causing problems on a couple of our tinderboxes.
Bismark (solaris/x86/egcs 1.03)  & speedracer (solaris/sparc/gcc 2.95.3) are
complaining that 'relocations against non-writable, allocatable sections remain'
when attempting to link at least libmoz_libart_lgpl.so  & libgklayout.so .  For
now, I'm going to attempt to use '-z textwarn' with -shared so that the tree
will build again.

Comment 14

[Philip Chee]

Gin, is this bug still valid? Can I assign this to you?

Comment 15

[Ginn Chen]

Not required.
Usually LD_LIBRARY_PATH should not be set in building time or running time.

IMHO:
User should take care of LD_LIBRARY_PATH by themselves.
Otherwise the build result is crappy anyway.