Resolved bugs are no longer struck out on dependency trees

RESOLVED FIXED in Bugzilla 2.18

Status

()

defect
RESOLVED FIXED
16 years ago
7 years ago

People

(Reporter: justdave, Assigned: kiko)

Tracking

({regression})

Bug Flags:
approval +
blocking2.18 +

Details

()

Attachments

(1 attachment, 2 obsolete attachments)

They are properly enclosed in class="bz_closed" however, it appears that the
stylesheet link at the top of the page is missing....
Flags: blocking2.18+
Keywords: regression
Target Milestone: --- → Bugzilla 2.18
This is a regression from bug 232397, apparently.  CCing the patch author and
committer from that bug.
Assignee

Comment 2

16 years ago
This regressed in a number of places, actually.

The central problem here is that the edit_bug.css file isn't included anywhere
right now beyond bug/show.html.tmpl and the styles were added there. I think a
proper solution would be to use a central CSS file for bugzilla and store
certain "bugzilla-wide" styles there -- I guess bug 69654 would have gotten us
closer to this. 

My solution is crude, but it works. When we do fix this we'll have to go
a-greppin for the css links I added here though..
Assignee

Updated

16 years ago
Assignee: myk → kiko
Status: NEW → ASSIGNED
Assignee

Updated

16 years ago
Attachment #144112 - Flags: review?
Assignee

Updated

16 years ago
Attachment #144112 - Flags: review?(myk)
Comment on attachment 144112 [details] [diff] [review]
kiko_v1: add link to edit_bug.css where necessary

>Index: en/default/list/list.html.tmpl
  ...
>-[% style_urls = [ "css/buglist.css" ] %]
>+[% style_urls = [ "css/buglist.css" "css/edit_bug.css" ] %]

You don't need it in this file, since bug lists don't strike through resolved
bugs.

Overall, I guess this is OK, although I'd much prefer for you to create a
"global.css" and move these style rules there.
Attachment #144112 - Flags: review?(myk)
Attachment #144112 - Flags: review?
Attachment #144112 - Flags: review-
Assignee

Comment 4

16 years ago
(In reply to comment #3)
> (From update of attachment 144112 [details] [diff] [review])
> >Index: en/default/list/list.html.tmpl
>   ...
> >-[% style_urls = [ "css/buglist.css" ] %]
> >+[% style_urls = [ "css/buglist.css" "css/edit_bug.css" ] %]
> 
> You don't need it in this file, since bug lists don't strike through resolved
> bugs.

You missed the fact that list.html.tmpl is what processes edit-multiple.html.tmpl.

> Overall, I guess this is OK, although I'd much prefer for you to create a
> "global.css" and move these style rules there.

Do you endorse this officially? Can I add it as a default stylesheet to
header.html.tmpl?

> You missed the fact that list.html.tmpl is what processes edit-multiple.html.tmpl.

Ah, ok, never mind then.

> > Overall, I guess this is OK, although I'd much prefer for you to create a
> > "global.css" and move these style rules there.
> 
> Do you endorse this officially? Can I add it as a default stylesheet to
> header.html.tmpl?

Yes, go ahead and add it.  Please do so in a way which is compatible with bug
69654 and post a note in that bug after checking in so its assignee knows to
take your changes into account.
Assignee

Comment 6

16 years ago
Assignee

Updated

16 years ago
Attachment #144112 - Attachment is obsolete: true
Assignee

Updated

16 years ago
Attachment #144160 - Flags: review?(myk)
Comment on attachment 144160 [details] [diff] [review]
kiko_v2: do the right thing<tm>

>Index: css/edit_bug.css
...
>-.bz_private { color: darkred ; background : #f3eeee ; }
>-.bz_disabled { color: #a0a0a0 ; }
>-
>-.bz_obsolete { text-decoration: line-through; }
>-.bz_inactive { text-decoration: line-through; }
>-.bz_closed { text-decoration: line-through; }

Let's contain the scope of this fix to just the changes in bug 232397, i.e.
don't move bz_private and bz_disabled over to global.css at this time.


>Index: css/global.css

This needs a license header (see buglist.css for an example).


>Index: template/en/default/global/header.html.tmpl
...
>       </style>
>     [% END %]
> 
>+    <link href="css/global.css" rel="stylesheet" type="text/css">

This should appear before the local style rules so that the local rules can
override it, or doesn't it matter?
Attachment #144160 - Flags: review?(myk) → review-
Assignee

Comment 8

16 years ago
It makes sense to have the global link come before the local styles -- I would
think the same for all linked style files, actually, but I'm not going to do
that here.
Attachment #144160 - Attachment is obsolete: true
Assignee

Updated

16 years ago
Attachment #144165 - Flags: review?(myk)
Comment on attachment 144165 [details] [diff] [review]
kiko_v3: use MPL header, place link in the right place

Looks good, works. r=myk
Attachment #144165 - Flags: review?(myk) → review+
Assignee

Updated

16 years ago
Flags: approval?
Flags: approval? → approval+
Assignee

Comment 10

16 years ago
Checked in (with no redness, hooray)
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.