Closed
Bug 237778
Opened 20 years ago
Closed 20 years ago
update filter list in t/004template
Categories
(Bugzilla :: Testing Suite, defect)
Bugzilla
Testing Suite
Tracking
()
RESOLVED
FIXED
Bugzilla 2.18
People
(Reporter: goobix, Assigned: goobix)
Details
Attachments
(1 file, 1 obsolete file)
1.14 KB,
patch
|
kiko
:
review+
|
Details | Diff | Splinter Review |
We should probably add the ics filter to the testing suite. It's already in 008 but it's missing from 004.
Assignee | ||
Comment 1•20 years ago
|
||
Assignee | ||
Updated•20 years ago
|
Attachment #144120 -
Flags: review?(kiko)
Comment 2•20 years ago
|
||
Vlad, help me out here and find out if the format here has to be compatible with the Template.pm format (i.e., filters taking arguments need to have be function generators).
Assignee | ||
Comment 3•20 years ago
|
||
Gerv, William: any know-how regarding the comment above?
Status: NEW → ASSIGNED
Comment 4•20 years ago
|
||
It should probably look like the bug_link line. ics => [ sub { return sub { return $_; } }, 1] ,
Comment 5•20 years ago
|
||
If you want to fix up the closed/obsolete/inactive filters we added yesterday too I'd be real happy about it.
Assignee | ||
Comment 6•20 years ago
|
||
Sorry for the delay.
Attachment #144120 -
Attachment is obsolete: true
Assignee | ||
Updated•20 years ago
|
Attachment #144120 -
Flags: review?(kiko)
Assignee | ||
Updated•20 years ago
|
Attachment #144471 -
Flags: review?(kiko)
Assignee | ||
Updated•20 years ago
|
Target Milestone: --- → Bugzilla 2.18
Comment 7•20 years ago
|
||
Comment on attachment 144471 [details] [diff] [review] Version 2 Looks good, but I'm wondering: when are these used if the tests are running fine now?
Attachment #144471 -
Flags: review?(kiko) → review+
Assignee | ||
Updated•20 years ago
|
Flags: approval?
Updated•20 years ago
|
Flags: approval? → approval+
Assignee | ||
Updated•20 years ago
|
Summary: ics filter not added to t/004filter test → update filter list in t/004template
Assignee | ||
Comment 8•20 years ago
|
||
Checking in t/004template.t; /cvsroot/mozilla/webtools/bugzilla/t/004template.t,v <-- 004template.t new revision: 1.32; previous revision: 1.31 done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•