update filter list in t/004template

RESOLVED FIXED in Bugzilla 2.18

Status

()

defect
RESOLVED FIXED
16 years ago
7 years ago

People

(Reporter: goobix, Assigned: goobix)

Tracking

unspecified
Bugzilla 2.18
Bug Flags:
approval +

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

16 years ago
We should probably add the ics filter to the testing suite. It's already in 008
but it's missing from 004.
Assignee

Comment 1

16 years ago
Assignee

Updated

16 years ago
Attachment #144120 - Flags: review?(kiko)

Comment 2

16 years ago
Vlad, help me out here and find out if the format here has to be compatible with
the Template.pm format (i.e., filters taking arguments need to have be function
generators).
Assignee

Comment 3

16 years ago
Gerv, William: any know-how regarding the comment above?
Status: NEW → ASSIGNED

Comment 4

16 years ago
It should probably look like the bug_link line.

            ics => [ sub { return sub { return $_; } }, 1] ,

Comment 5

16 years ago
If you want to fix up the closed/obsolete/inactive filters we added yesterday
too I'd be real happy about it.
Assignee

Comment 6

16 years ago
Posted patch Version 2Splinter Review
Sorry for the delay.
Attachment #144120 - Attachment is obsolete: true
Assignee

Updated

16 years ago
Attachment #144120 - Flags: review?(kiko)
Assignee

Updated

16 years ago
Attachment #144471 - Flags: review?(kiko)
Assignee

Updated

16 years ago
Target Milestone: --- → Bugzilla 2.18

Comment 7

16 years ago
Comment on attachment 144471 [details] [diff] [review]
Version 2

Looks good, but I'm wondering: when are these used if the tests are running
fine now?
Attachment #144471 - Flags: review?(kiko) → review+
Assignee

Updated

16 years ago
Flags: approval?
Flags: approval? → approval+
Assignee

Updated

16 years ago
Summary: ics filter not added to t/004filter test → update filter list in t/004template
Assignee

Comment 8

16 years ago
Checking in t/004template.t;
/cvsroot/mozilla/webtools/bugzilla/t/004template.t,v  <--  004template.t
new revision: 1.32; previous revision: 1.31
done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.