237838 - resolution wrong in CheckCanChangeField

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Tom Karzes]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.1) Gecko/20021003
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.1) Gecko/20021003

I modified CheckCanChangeField to restrict certain "resolution" values, and I
found that the newvalue was sometimes wrong, depending on where it came from (an
example is when someone tries to mark a bug as a "duplicate").  This is because
it's picking the new value out of a form field that's only defined in some of
the cases.  The same situation applies to the "bug_status" field, but that cases
works correctly because of a hack at the bottom of ChangeStatus in which the new
value is forced into the form.  I made a similar change to ChangeResolution
which seems to have fixed the problem:

sub ChangeResolution {
    my ($str) = (@_);
    if ($str ne $::dontchange) {
        DoComma();
        $::query .= "resolution = " . SqlQuote($str);
        $::FORM{'resolution'} = $str; # Used later by CheckCanChangeField
    }
}



Reproducible: Always
Steps to Reproduce:
1. Customize CheckCanChangeField to check the new value of the "resolution" field.
2. Use one of the specialized knob settings to change the resolution of a bug
(e.g., mark the bug as a duplicate)

Actual Results:  
CheckCanChangeField sees the wrong value for the "resolution" field.


Expected Results:  
CheckCanChangeField should have seen the correct value for the "resolution" field.

Comment 1

[Dave Miller [:justdave]]

Hmm, this makes sense to me.  

Comment 2

[Gervase Markham [:gerv]]

Yep, seems sensible at first look.

Gerv

Comment 3

[Gervase Markham [:gerv]]

Attachment: Patch v.1

This should do the trick.

Gerv

Comment 4

[Gervase Markham [:gerv]]

Comment on attachment 145613 [details] [diff] [review]
Patch v.1

Tom: could you check this is right?

Gerv

Comment 5

[Tom Karzes]

Looks good to me :)

Comment 6

[Dave Miller [:justdave]]

Comment on attachment 145613 [details] [diff] [review]
Patch v.1

r=justdave

This is going to get redone when they get around to sanitizing process_bug.cgi
for %::FORM usage, but it should be easy enough for them to catch then. :)

Comment 7

[Dave Miller [:justdave]]

Gerv: this appears to be your patch.  Care to check it in?

Comment 8

[Gervase Markham [:gerv]]

Sure. :-)

Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.204; previous revision: 1.203
done

Gerv