Closed Bug 237857 Opened 20 years ago Closed 20 years ago

Block Images menu item is mispositioned in Standalone

Categories

(SeaMonkey :: MailNews: Message Display, defect)

x86
Windows 2000
defect
Not set
minor

Tracking

(Not tracked)

VERIFIED FIXED
mozilla1.8alpha1

People

(Reporter: mcow, Assigned: neil)

Details

(Keywords: regression)

Attachments

(1 file)

In the three-pane message preview window, the context menu item for "Block 
Images from this Server" (and "Unblock...") appears directly under the View 
Images item.  However, in the Standalone window, the menu item appears at the 
top of the menu.  These menus should be identical.

This is true for the Image context menu and the Image Link context menu.

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7b) Gecko/20040316
Also 1.6 Final.
I've looked at the code for this and it's a bit of a mystery.  The menu items in 
question do not reside in mailWindowOverlay.xul, unlike all the other menu items 
in these context menus.  They apparently are being inserted by some other 
handler (presumably the handler which is also hiding those image-related menu 
items that *are* defined in the Mail program's XUL).

This is exceptionally bogus design and ought to be reworked.
Regression from bug 78360.
Keywords: regression
OK, so the imageblocker context menu items were getting overlaid before the
context menu was overlaid, this fixes it by centralizing the overlay location.
The imageblocker overlay could probably do with some cleanup too.
Assignee: sspitzer → neil.parkwaycc.co.uk
Status: NEW → ASSIGNED
Attachment #144623 - Flags: superreview?(mscott)
Attachment #144623 - Flags: review?(mscott)
Attachment #144623 - Flags: superreview?(mscott)
Attachment #144623 - Flags: superreview+
Attachment #144623 - Flags: review?(mscott)
Attachment #144623 - Flags: review+
Target Milestone: --- → mozilla1.8alpha
Comment on attachment 144623 [details] [diff] [review]
Centralize the overlay

Looking to fix this UI regression with a low-risk patch (ideally other stuff
should be done as well, but probably not for 1.7)
Attachment #144623 - Flags: approval1.7?
Comment on attachment 144623 [details] [diff] [review]
Centralize the overlay

a=chofmann for 1.7
Attachment #144623 - Flags: approval1.7? → approval1.7+
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Verified with
  Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7b) Gecko/20040326

Thanks, Neil.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: