If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Block Images menu item is mispositioned in Standalone

VERIFIED FIXED in mozilla1.8alpha1

Status

SeaMonkey
MailNews: Message Display
--
minor
VERIFIED FIXED
14 years ago
13 years ago

People

(Reporter: Mike Cowperthwaite, Assigned: neil@parkwaycc.co.uk)

Tracking

({regression})

Trunk
mozilla1.8alpha1
x86
Windows 2000
regression

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

3.14 KB, patch
Scott MacGregor
: review+
Scott MacGregor
: superreview+
chris hofmann
: approval1.7+
Details | Diff | Splinter Review
(Reporter)

Description

14 years ago
In the three-pane message preview window, the context menu item for "Block 
Images from this Server" (and "Unblock...") appears directly under the View 
Images item.  However, in the Standalone window, the menu item appears at the 
top of the menu.  These menus should be identical.

This is true for the Image context menu and the Image Link context menu.

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7b) Gecko/20040316
Also 1.6 Final.
(Reporter)

Comment 1

14 years ago
I've looked at the code for this and it's a bit of a mystery.  The menu items in 
question do not reside in mailWindowOverlay.xul, unlike all the other menu items 
in these context menus.  They apparently are being inserted by some other 
handler (presumably the handler which is also hiding those image-related menu 
items that *are* defined in the Mail program's XUL).

This is exceptionally bogus design and ought to be reworked.
(Assignee)

Comment 2

14 years ago
Regression from bug 78360.
Keywords: regression
(Assignee)

Comment 3

14 years ago
Created attachment 144623 [details] [diff] [review]
Centralize the overlay

OK, so the imageblocker context menu items were getting overlaid before the
context menu was overlaid, this fixes it by centralizing the overlay location.
The imageblocker overlay could probably do with some cleanup too.
Assignee: sspitzer → neil.parkwaycc.co.uk
Status: NEW → ASSIGNED
(Assignee)

Updated

14 years ago
Attachment #144623 - Flags: superreview?(mscott)
Attachment #144623 - Flags: review?(mscott)

Updated

14 years ago
Attachment #144623 - Flags: superreview?(mscott)
Attachment #144623 - Flags: superreview+
Attachment #144623 - Flags: review?(mscott)
Attachment #144623 - Flags: review+
(Assignee)

Updated

14 years ago
Target Milestone: --- → mozilla1.8alpha
(Assignee)

Comment 4

14 years ago
Comment on attachment 144623 [details] [diff] [review]
Centralize the overlay

Looking to fix this UI regression with a low-risk patch (ideally other stuff
should be done as well, but probably not for 1.7)
Attachment #144623 - Flags: approval1.7?

Comment 5

14 years ago
Comment on attachment 144623 [details] [diff] [review]
Centralize the overlay

a=chofmann for 1.7
Attachment #144623 - Flags: approval1.7? → approval1.7+
(Assignee)

Comment 6

14 years ago
Fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
(Reporter)

Comment 7

14 years ago
Verified with
  Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7b) Gecko/20040326

Thanks, Neil.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.