237857 - Block Images menu item is mispositioned in Standalone

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Mike Cowperthwaite]

In the three-pane message preview window, the context menu item for "Block 
Images from this Server" (and "Unblock...") appears directly under the View 
Images item.  However, in the Standalone window, the menu item appears at the 
top of the menu.  These menus should be identical.

This is true for the Image context menu and the Image Link context menu.

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7b) Gecko/20040316
Also 1.6 Final.

Comment 1

[Mike Cowperthwaite]

I've looked at the code for this and it's a bit of a mystery.  The menu items in 
question do not reside in mailWindowOverlay.xul, unlike all the other menu items 
in these context menus.  They apparently are being inserted by some other 
handler (presumably the handler which is also hiding those image-related menu 
items that *are* defined in the Mail program's XUL).

This is exceptionally bogus design and ought to be reworked.

Comment 2

[[e-mail]]

Regression from bug 78360.

Comment 3

[[e-mail]]

Attachment: Centralize the overlay

OK, so the imageblocker context menu items were getting overlaid before the
context menu was overlaid, this fixes it by centralizing the overlay location.
The imageblocker overlay could probably do with some cleanup too.

Comment 4

[[e-mail]]

Comment on attachment 144623 [details] [diff] [review]
Centralize the overlay

Looking to fix this UI regression with a low-risk patch (ideally other stuff
should be done as well, but probably not for 1.7)

Comment 5

[chris hofmann]

Comment on attachment 144623 [details] [diff] [review]
Centralize the overlay

a=chofmann for 1.7

Comment 6

[[e-mail]]

Fix checked in.

Comment 7

[Mike Cowperthwaite]

Verified with
  Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7b) Gecko/20040326

Thanks, Neil.