237959 - Mail Integration Label should be below icon, not next to it

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Robert Accettura [:raccettura]]

If you set your toolbar to show "icons and text", the text for the mail icon
appears to the right, rather than below, like all the other elements in the toolbar.

I have a patch.

Comment 1

[Robert Accettura [:raccettura]]

Attachment: Screenshot of bug

Comment 2

[Robert Accettura [:raccettura]]

Attachment: Patch v1

This should take care of it.

Comment 3

[Robert Accettura [:raccettura]]

No idea who should r= and who should sr=

So if someone wants to be my friend and take care of that, I would appreciate it.

Comment 4

[Mike Connor [:mconnor]]

SR isn't needed for Firefox

Comment 5

[Robert Accettura [:raccettura]]

(In reply to comment #4)
> SR isn't needed for Firefox

Realized, that's why I just requested an r=

Thanks for checking up though :-)

Now hopefully Ben will squeeze this into his busy schedule before the sun
expands and devours the earth.

Comment 6

[Robert Accettura [:raccettura]]

We should get this in 0.9, since it's harmless UI polish, and a good solder
always polishes their boots until they shine.

Comment 7

[Ali Ebrahim]

This is a minor polish bug. It certainly shouldn't block Firefox 0.9 which is a
feature-driven release. Maybe a possible candidate for blocking 1.0beta or 1.0,
though.

Comment 8

[Robert Accettura [:raccettura]]

Is there anyone else beside ben that could r= a firefox bug?  He's very busy.

Comment 9

[Mike Connor [:mconnor]]

will check this in as part of my next checkin blitz

Comment 10

[Robert Accettura [:raccettura]]

oh, so you were able to review all along, but kept it quiet huh?  I see how it
is ;-)

Comment 11

[Mike Connor [:mconnor]]

nah, there wouldn't be a huge backlog of stuff if I could have handled it earlier :)

Comment 12

[Mike Connor [:mconnor]]

checked in branch and trunk, 2004-05-06 16:46

Comment 13

[Robert Accettura [:raccettura]]

Thanks Mike

Comment 14

[Robert Accettura [:raccettura]]

looks good in 
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a) Gecko/20040507
Firefox/0.8.0+