Closed
Bug 238025
Opened 22 years ago
Closed 22 years ago
HTML table not opened in list.html.tmpl when no keywords defined
Categories
(Bugzilla :: User Interface, defect, P3)
Bugzilla
User Interface
Tracking
()
RESOLVED
FIXED
Bugzilla 2.18
People
(Reporter: rudolf.ramler, Assigned: rudolf.ramler)
Details
Attachments
(1 file)
|
380 bytes,
patch
|
goobix
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; .NET CLR 1.0.3705; .NET CLR 1.1.4322)
Build Identifier:
The loop in list.html.tmpl will not be executed when no keywords are defined.
The HTML table (showing the keywords) is opened inside the loop, but closed
outside. Thus, if no keywords are defined an additional </table> corrupts the
(customized) layout.
Reproducible: Always
Steps to Reproduce:
Updated•22 years ago
|
Assignee: myk → vlad
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking2.18?
Target Milestone: --- → Bugzilla 2.18
| Assignee | ||
Comment 1•22 years ago
|
||
Updated•22 years ago
|
Attachment #144354 -
Flags: review?(vlad)
Comment 2•22 years ago
|
||
Comment on attachment 144354 [details] [diff] [review]
Some additional lines to open the HTML table every time
This makes our approach on table_header similar with the one that we use for
table_footer.
count() is a method for the loop iterator, but the "()" are optional. We use
them in other places so this looks ok regarding consistency as well.
Attachment #144354 -
Flags: review?(vlad) → review+
Updated•22 years ago
|
Assignee: vlad → rudolf.ramler
Flags: approval?
Updated•22 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P3
Updated•22 years ago
|
Flags: blocking2.18?
Flags: blocking2.18+
Flags: approval?
Flags: approval+
Comment 3•22 years ago
|
||
Thanks Rudolf!
Checking in list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/keywords/list.html.tmpl,v
<-- list.html.tmpl
new revision: 1.4; previous revision: 1.3
done
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•