238036 - Build fail at tools/leaky/bfd.cpp with error "xpcom-config.h" not found

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Eddahbi Karim]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040319
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040319

I was building mozilla-1.7-beta and It fails on this :

g++ -o bfd.o -c -DOSTYPE=\"Linux2.6\" -DOSARCH=\"Linux\"   -I../../dist/include
-I../../dist/include -I/home/gamer/Sources/mozilla/dist/include/nspr    
-I/usr/X11R6/include   -fPIC  -I/usr/X11R6/include -fno-rtti -fno-exceptions
-Wall -Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth
-Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-long-long -pedantic
-fshort-wchar -pthread -pipe  -DDEBUG -D_DEBUG -DDEBUG_gamer -DTRACING -g
-fno-inline  -I/usr/X11R6/include -DMOZILLA_CLIENT -include
../../mozilla-config.h -Wp,-MD,.deps/bfd.pp bfd.cpp
Dans le fichier inclus à partir de bfd.cpp:13:
leaky.h:22:47: xpcom-config.h : Aucun fichier ou répertoire de ce type
In file included from bfd.cpp:13:
leaky.h:54: error: erreur d'analyse syntaxique before `;' token
gmake[2]: *** [bfd.o] Erreur 1
gmake[2]: Leaving directory `/home/gamer/Sources/mozilla/tools/leaky'
gmake[1]: *** [tier_50] Erreur 2
gmake[1]: Leaving directory `/home/gamer/Sources/mozilla'
make: *** [default] Erreur 2

Here are my configure flags :
./configure --prefix=/opt/Mozilla --sysconfdir=/etc
--enable-default-toolkit=gtk2 --enable-calendar --enable-xft --disable-svg
--enable-leaky --enable-strip --enable-xterm-updates
--with-gtk-prefix=/opt/Gnome26/lib/

I did a small patch that fixes the problem, maybe you can take a look at it


Reproducible: Always
Steps to Reproduce:
1. Pick up the sources of Mozilla 1.7 beta
2. Pass the flag --enable-leaky to the configure script
3. Then make

Actual Results:  
It fails with that error :

g++ -o bfd.o -c -DOSTYPE=\"Linux2.6\" -DOSARCH=\"Linux\"   -I../../dist/include
-I../../dist/include -I/home/gamer/Sources/mozilla/dist/include/nspr    
-I/usr/X11R6/include   -fPIC  -I/usr/X11R6/include -fno-rtti -fno-exceptions
-Wall -Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth
-Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-long-long -pedantic
-fshort-wchar -pthread -pipe  -DDEBUG -D_DEBUG -DDEBUG_gamer -DTRACING -g
-fno-inline  -I/usr/X11R6/include -DMOZILLA_CLIENT -include
../../mozilla-config.h -Wp,-MD,.deps/bfd.pp bfd.cpp
Dans le fichier inclus à partir de bfd.cpp:13:
leaky.h:22:47: xpcom-config.h : Aucun fichier ou répertoire de ce type
In file included from bfd.cpp:13:
leaky.h:54: error: erreur d'analyse syntaxique before `;' token
gmake[2]: *** [bfd.o] Erreur 1
gmake[2]: Leaving directory `/home/gamer/Sources/mozilla/tools/leaky'
gmake[1]: *** [tier_50] Erreur 2
gmake[1]: Leaving directory `/home/gamer/Sources/mozilla'
make: *** [default] Erreur 2


Expected Results:  
Find xpcom-config.h which is in (topsrcdir)/xpcom/xpcom-config.h

Comment 1

[Eddahbi Karim]

Attachment: This should fix the problem

Comment 2

[cls]

Comment on attachment 144357 [details] [diff] [review]
This should fix the problem

http://www.mozilla.org/hacking/portable-cpp.html#include_simple_filename

The proper fix would be to add xpcom to the REQUIRES variable in the Makefile.

Comment 3

[cls]

*** Bug 243497 has been marked as a duplicate of this bug. ***

Comment 4

[cls]

Attachment: add xpcom to REQUIRES

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Confirming bug since cls has spun a patch.

Comment 6

[cls]

The patch has been checked in.