238038 - Opening up Toolbar Customization in Help window when Toolbar Customization is open in Help Viewer causes dialog to not be able to close.

Status: RESOLVED WORKSFORME

(Firefox :: Toolbars and Customization, defect)

Description

[R.J. Keller]

If you open up the Help Viewer, open up Firefox Toolbar Customization, and then
open up Firefox Help Toolbar Customization, the Firefox Toolbar Customization
dialog will loose all options in the dialog and can't be closed without closing
Firefox.

Bug reproduced using Firefox 0.8+ BuildID 20040319 and Firefox 0.8 release (with
Firebird Help XPI installed) on Windows XP Home Edition. These are official
mozilla.org builds, not ones I made on my own.

Steps to reproduce:
1) Open Firefox Help (Help -> Help Contents)
2) Open Toolbar Customization (in Firefox window, right-click on Toolbar ->
Customize...)
3) Open up Firefox Help Toolbar Customization (in Firefox Help window,
right-click on Toolbar -> Customize...)

Actual Results:
Buttons go away in the Firefox Toolbar Customization dialog, and the dialog
cannot be closed without closing Firefox. Firefox Help Toolbar Customization was
not opened.

Expected Results:
We should either close the Firefox Toolbar Customization dialog or allow them to
both be opened at the same time.

Comment 1

[R.J. Keller]

Attachment: Screenshot of bug

This is a screenshot of the bug showing the Toolbar Customization dialog after
the Help one has been open.

The Help Toolbar Customization dialog is not opened and the FB dialog has lost
all function.

Comment 2

[Anders Pedersen]

Confirmed.

- Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a) Gecko/20040503
Firefox/0.8.0+
- Microsoft Windows 2000 Pro 5.00.2195 SP4

Comment 3

[miahz]

I see this in 0.9x, but also, the Help window's always-on-top-edness conflicts
with the Customize Toolbar window in Help and in the main browser window.  It's
almost certainly related to bug 216426, but i figured i'd start here since this
one also deals with the Customize Toolbar window.

Entering customize mode in the browser window while Help is open causes the
palette to open under the browser.  If you click on the browser window or
otherwise bring focus to it (ALT-TAB) the palette comes up.  But then, if you
make any mode or icons size changes or drop an object onto a toolbar, it falls
back under the browser window.  The Help window palette has a similar, but
slightly different behavior when it's open and you click on other windows.

As for not being able to close the Customize window when it's blank, here's a
little trick i figured out when the palette opened at the bottom of the screen
and the Close button was hidden:
click on the palette, and hit ALT-F4.
Since it's a window, that will close the Customize Toolbar palette.  You just
have to make sure it has focus, or you might end up Closing the main browser
window instead.

Comment 4

[R.J. Keller]

ahh! Thanks for the workaround! But why are the contents going blank in the
first place? They're both two separate XUL windows.

Comment 5

[Worcester12345]

RJ Keller, are you still seeing this after 1.0? How about in trunk?

Comment 6

[R.J. Keller]

(In reply to comment #5)
> RJ Keller, are you still seeing this after 1.0? How about in trunk?

I see this, but it's a bit different. The Firefox Toolbar Customization window
now closes instead of showing a blank window. Found this on Firefox 1.0 on
Windows 2000.

Comment 7

[Phil Ringnalda (:philor)]

The fix for this would have been to fix the callers, so that they called window.open or window.openDialog or whatever they were calling at the time with different window names for help and browser, but now that Help toolbar customization is gone, it's too late for that.