238050 - mIRC colours 0 and 1 shouldn't be treated specially

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Oren Shahar]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040206 Firefox/0.8
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040206 Firefox/0.8

The colors 0 and 1 are reversed so that 0 is black and 1 is white whereas on
mIRC, 0 is white and 1 is black.

Reproducible: Always
Steps to Reproduce:
1. Type %C
2. Number 0 and 1 are reversed
3. Get confused

Actual Results:  
0 leads to black and 1 leads to white

Expected Results:  
0 should make white text and 1 should make black text

Comment 1

[ken Phillis Jr]

I also konw of this bug, and here is a small faq...

http://www.ircle.com/colorfaq.shtml

Comment 2

[James Ross]

Attachment: Fix mIRC colour codes

This changes colours 0 and 1 back to what they should be per-mIRC, and stops
them being treated specially. It also fixes %R (reverse video) to NOT assume
anything about the fg colour when not set.

Comment 3

[Robert Utasi [:hunboy]]

The correct Mirc color codes are:

00: #FFFFFF
01: #000000
02: #00007F
03: #009300
04: #FF0000
05: #7F0000
06: #9C009C
07: #FC7F00
08: #FFFF00
09: #00FC00
10: #009393
11: #00FFFF
12: #0000FC
13: #FF00FF
14: #7F7F7F
15: #D2D2D2

(backgroundcolors too)

The last modified colors are not too good's , perhaps we can't see normally the
unogame cards with that colors.

I've read the correct color codes from the mirc v6.02. (screenshot+colorzilla ;) )

Please check your settings at the output-base.css file

Thnx :)

Comment 4

[:Gijs (he/him)]

Attachment: Patch using other color values

New patch that actually applies once more, and uses the colour values mentioned in comment #3, which are correct, as they are also in the mirc.ini mIRC configuration file as the default colour set.

Comment 5

[Samuel Sieb]

Comment on attachment 203935 [details] [diff] [review]
Patch using other color values

it would be good if we could determine the motifs colors to handle this better

Comment 6

[James Ross]

Checked in --> FIXED.