238089 - Download of same filename's -1/-2/etc. should be appended right before last segment

Status: RESOLVED WONTFIX

(Toolkit :: Downloads API, defect)

Description

[Tim De Pauw]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7b) Gecko/20040320 Firefox/0.8.0+ (scragz)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7b) Gecko/20040320 Firefox/0.8.0+ (scragz)

When I re-download a file whose name is comprised of more than 2 segments,
separated by a dot, Firefox will add the -1 extension after the first part; e.g.
downloading "blah.test.file.txt" twice will save as "blah-1.test.file.txt",
while "blah.test.file-1.txt" would make more sense to me.

Reproducible: Always
Steps to Reproduce:





Sorry if the bug exists, I had no idea what to search for.

Comment 1

[Jesse Ruderman]

Some files have multiple extensions.  Examples: firefox-i686-pc-linux-gnu.tar.gz
and Firefox-mac.dmg.gz.  For those, it makes sense to put the number before the
first dot (rather than the last dot).

Comment 2

[Ali Ebrahim]

*** This bug has been marked as a duplicate of 231048 ***

Comment 3

[Jesse Ruderman]

Not a dup of bug 231048.  Bug 231048 is about changing numbers in the actual
filename.  This is about adding numbers to the "wrong" section when numbers have
to be added.

Comment 4

[Tim De Pauw]

Indeed. About the multiple extensions: ideally, there would be an intelligent
detection mechanism. How many "multiple" extensions do you know besides .tar.gz?

Comment 5

[Ben Fowler]

Further examples would be .en.html, .c.o ...

I work on the basis that any number of extensions in in any order
should be allowed in a filename.

Since I would be surprised if any (artifical) intelligence would handle
that open ended question, it would seem sense to either use always
the first dot, always the last dot, or tag '-nnn' at the very end.

My first choice would be the last of those, then to use the last dot:
which makes it easiest to see that the agent has changed the name. If the
best opinion is to use the first dot, that's fine.

IMHO this is a metadata question & I feel that the file name should be 
entirely under control of the user.

Ben 

Comment 6

[timeless]

don't ask that question 
.tar.bz2
.dmg.gz
...

Comment 7

[Tim De Pauw]

Okay, I hadn't thought of those examples, sorry.

But perhaps there should at least be an about:config option for this. I myself
am no big fan of appending it all the way at the end, since that will break file
associations. But I would still prefer it before the last part instead of the
way it is now, because it's more common that way, or at least for the stuff I
download. Hence the about:config option...

Comment 8

[Mike Connor [:mconnor]]

a better heuristic/convention is certainly possible, but this isn't the answer.
 There's no way to do this in a sane and future-proof way, since short of trying
to hardcode certain strings there isn't a way to determine if a given ending
should be one or two segments or even more, and that basically fails if there's
another filetype we don't handle well.

the current behaviour is less potentially destructive than this, however bug
231048 and probably some other cases should be corrected.

marking WONTFIX, if a better heuristic/naming convention for copies exists, file
a new bug.

Comment 9

[Mike Connor [:mconnor]]

a better heuristic/convention is certainly possible, but this isn't the answer.
 There's no way to do this in a sane and future-proof way, since short of trying
to hardcode certain strings there isn't a way to determine if a given ending
should be one or two segments or even more, and that basically fails if there's
another filetype we don't handle well.

the current behaviour is less potentially destructive than this, however bug
231048 and probably some other cases should be corrected.

marking WONTFIX, if a better heuristic/naming convention for copies exists, file
a new bug.