Closed Bug 238409 Opened 17 years ago Closed 17 years ago

Regression in attributes parsing (cellpadding)

Categories

(Core :: DOM: Core & HTML, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: ecfbugzilla, Assigned: ecfbugzilla)

Details

(Keywords: regression)

Attachments

(3 files)

Build 20040311 parses <table cellpadding> as <table cellpadding="0">, the
previous behavior was to ignore the attribute (which resulted in something like
<table cellpadding="2">). This seems to be a regression from 232706, the patch
was checked in on Mar 3 18:06.
Assignee: general → bugmail
I meant cellspacing, not cellpadding in my report (cellpadding has the same
parsing problem but it is 0 by default).
Attached patch Proposed patchSplinter Review
Attachment #144669 - Flags: review?(bugmail)
Attachment #144669 - Flags: superreview?(jst)
Flags: blocking1.7?
Comment on attachment 144669 [details] [diff] [review]
Proposed patch

sr=jst, and requesting 1.7 approval for this regression.
Attachment #144669 - Flags: superreview?(jst)
Attachment #144669 - Flags: superreview+
Attachment #144669 - Flags: approval1.7?
This is a pretty bad regression. For many attributes we now treat an invalid
value as '0' whereas we used to ignore the attribute entierly. This affects both
how we render the element and the DOM.

The fix is very simple and should be very safe.
Comment on attachment 144669 [details] [diff] [review]
Proposed patch

a=asa (on behalf of drivers) for checkin to 1.7
Attachment #144669 - Flags: approval1.7? → approval1.7+
Fix checked in.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Flags: blocking1.7?
Attachment #246975 - Flags: review?(jst)
Attachment #246975 - Flags: review?(jst) → review+
Checking in test_bug238409.html;
/cvsroot/mozilla/testing/mochitest/tests/test_bug238409.html,v  <--  test_bug238409.html
initial revision: 1.1
done
Flags: in-testsuite+
Assignee: jonas → trev
Component: DOM: Core → DOM: Core & HTML
QA Contact: ian → general
You need to log in before you can comment on or make changes to this bug.