406 bytes, text/html
1.74 KB, patch
|Details | Diff | Splinter Review|
1.50 KB, text/html
Build 20040311 parses <table cellpadding> as <table cellpadding="0">, the previous behavior was to ignore the attribute (which resulted in something like <table cellpadding="2">). This seems to be a regression from 232706, the patch was checked in on Mar 3 18:06.
Created attachment 144668 [details] Testcase, the last table is rendered differently I meant cellspacing, not cellpadding in my report (cellpadding has the same parsing problem but it is 0 by default).
Attachment #144669 - Flags: review?(bugmail) → review+
Comment on attachment 144669 [details] [diff] [review] Proposed patch sr=jst, and requesting 1.7 approval for this regression.
This is a pretty bad regression. For many attributes we now treat an invalid value as '0' whereas we used to ignore the attribute entierly. This affects both how we render the element and the DOM. The fix is very simple and should be very safe.
Comment on attachment 144669 [details] [diff] [review] Proposed patch a=asa (on behalf of drivers) for checkin to 1.7
Attachment #144669 - Flags: approval1.7? → approval1.7+
Fix checked in.
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
Created attachment 246975 [details] mochitest compatible testcase
Attachment #246975 - Flags: review?(jst)
Checking in test_bug238409.html; /cvsroot/mozilla/testing/mochitest/tests/test_bug238409.html,v <-- test_bug238409.html initial revision: 1.1 done
You need to log in before you can comment on or make changes to this bug.