Regression in attributes parsing (cellpadding)

RESOLVED FIXED

Status

()

RESOLVED FIXED
15 years ago
11 years ago

People

(Reporter: gaubugzilla, Assigned: gaubugzilla)

Tracking

({regression})

Trunk
x86
Windows XP
regression
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

15 years ago
Build 20040311 parses <table cellpadding> as <table cellpadding="0">, the
previous behavior was to ignore the attribute (which resulted in something like
<table cellpadding="2">). This seems to be a regression from 232706, the patch
was checked in on Mar 3 18:06.
(Assignee)

Updated

15 years ago
Assignee: general → bugmail
(Assignee)

Comment 1

15 years ago
Created attachment 144668 [details]
Testcase, the last table is rendered differently

I meant cellspacing, not cellpadding in my report (cellpadding has the same
parsing problem but it is 0 by default).
(Assignee)

Comment 2

15 years ago
Created attachment 144669 [details] [diff] [review]
Proposed patch
(Assignee)

Updated

15 years ago
Attachment #144669 - Flags: review?(bugmail)
(Assignee)

Updated

15 years ago
Attachment #144669 - Flags: superreview?(jst)
Flags: blocking1.7?
Comment on attachment 144669 [details] [diff] [review]
Proposed patch

sr=jst, and requesting 1.7 approval for this regression.
Attachment #144669 - Flags: superreview?(jst)
Attachment #144669 - Flags: superreview+
Attachment #144669 - Flags: approval1.7?
This is a pretty bad regression. For many attributes we now treat an invalid
value as '0' whereas we used to ignore the attribute entierly. This affects both
how we render the element and the DOM.

The fix is very simple and should be very safe.

Comment 5

15 years ago
Comment on attachment 144669 [details] [diff] [review]
Proposed patch

a=asa (on behalf of drivers) for checkin to 1.7
Attachment #144669 - Flags: approval1.7? → approval1.7+
Fix checked in.
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
Flags: blocking1.7?
(Assignee)

Comment 7

12 years ago
Created attachment 246975 [details]
mochitest compatible testcase
Attachment #246975 - Flags: review?(jst)
Attachment #246975 - Flags: review?(jst) → review+

Comment 8

12 years ago
Checking in test_bug238409.html;
/cvsroot/mozilla/testing/mochitest/tests/test_bug238409.html,v  <--  test_bug238409.html
initial revision: 1.1
done
Flags: in-testsuite+
(Assignee)

Updated

12 years ago
Assignee: jonas → trev

Updated

11 years ago
Component: DOM: Core → DOM: Core & HTML
QA Contact: ian → general
You need to log in before you can comment on or make changes to this bug.