Checksetup emits errors on 2.16 -> 2.17 upgrade if groupset has never been used

RESOLVED FIXED in Bugzilla 2.18

Status

()

defect
P1
blocker
RESOLVED FIXED
15 years ago
7 years ago

People

(Reporter: bugreport, Assigned: bugreport)

Tracking

2.17.7
Bugzilla 2.18
Bug Flags:
approval +

Details

Attachments

(1 attachment)

Assignee

Description

15 years ago
If a 2.16 site has never changed a groupset, the FieldID for "groupset" will
never have been defined.  Checksetup will then stubmble when it tries to convert
the bugs_activity. (Which doesn't need to be done, since there is none)
Assignee

Updated

15 years ago
Priority: -- → P1
Target Milestone: --- → Bugzilla 2.18
Assignee

Comment 1

15 years ago
Posted patch PatchSplinter Review
It looks big, but it is almost all whitespace changes.	Only do conversion of
activity records if the groupset fielddef was found.
Assignee

Updated

15 years ago
Assignee: zach → bugreport
Status: NEW → ASSIGNED
Assignee

Updated

15 years ago
Attachment #144658 - Flags: review?(zach)
Attachment #144658 - Flags: review?(zach) → review+
Assignee

Comment 2

15 years ago
checked in
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.