23859 - Convert nsIRegistry to take wstring instead of string

Status: VERIFIED FIXED

(Core :: XPCOM, defect, P2)

Description

[Daniel Veditz [:dveditz]]

The underlying registry stores in utf8, but people calling the API don't seem
to know that. Especially JS/XPConnect which does the wrong conversion for
"string" arguments. By making the API Unicode we know we can do the safe
conversion inside the nsIRegistry class.

Comment 1

[Daniel Veditz [:dveditz]]

Too destabilizing to attempt in M13, need to do first thing in M14

Comment 2

[Daniel Veditz [:dveditz]]

Setting second tier M14 priorities

Comment 3

[leger]

Can you rely on the registry to do this XP?  Putting on PDT- radar for beta1.  
Would not hold for beta.  bobj, your thoughts any different?

Comment 4

[Daniel Veditz [:dveditz]]

Unicode -> UTF8 is a lossless mechanical bit re-arrangement, it's not a 
traditional character set conversion. This bug blocks creation of profiles when 
the name or directory contains 8-bit characters. E.g. Japanese or European 
users, Mac users with funny chars like that script "f" in their folder names, 
etc.

Comment 5

[bobj]

Cleared PDT- for reconsideration.
As dveditz points out, this would restrict profiles and pathnames (we also
have some resource URLs in the registry) to ASCII.

Comment 6

[racham]

At present we are not able to test any of the profile manager functionalities 
due this limitation. This inturns makes it difficult for other components to use 
the profile service on the i18n systems. We should consider this implementation 
for beta as this means making the browser i18n friendly.

Making bug 15264 (making profile manager i18n compatible) dependent on this.

Comment 7

[racham]

Adding gayatri to cc list.

Comment 8

[Daniel Veditz [:dveditz]]

I hope to get this checked in on 2/12 to give the profile manager team time to 
adapt to the new interface.

Comment 9

[Daniel Veditz [:dveditz]]

Fixed

Comment 10

[Daniel Veditz [:dveditz]]

The enumeration interface was not converted, the crucial one for the profile 
code

Comment 11

[Daniel Veditz [:dveditz]]

Added the wstring apis to the enumerator objects as well.

Comment 12

[leger]

Gona have to trust you words on this one, unless you have a way for jimmylee to 
vefify.  Marking Verified.  Please reopen is a problem

Comment 13

[bobj]

Cc'd msanz and teruko, so they can test with intl profile names/directories.