Use of uninitialized value in concatenation in Bugzilla/CGI.pm

RESOLVED FIXED in Bugzilla 2.18

Status

()

Bugzilla
Bugzilla-General
--
trivial
RESOLVED FIXED
13 years ago
4 years ago

People

(Reporter: corporate_gadfly, Assigned: corporate_gadfly)

Tracking

unspecified
Bugzilla 2.18
Bug Flags:
approval +

Details

Attachments

(1 attachment)

(Assignee)

Description

13 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040302 Galeon/1.3.13
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040302 Galeon/1.3.13

I get tons of these errors in the error_log:

Use of uninitialized value in concatenation (.) or string at Bugzilla/CGI.pm
line 121

Here's a diff that takes out the extra $ sign after boundary:
Index: Bugzilla/CGI.pm
===================================================================
RCS file: /cvsroot/mozilla/webtools/bugzilla/Bugzilla/CGI.pm,v
retrieving revision 1.9
diff -r1.9 CGI.pm
121c121
<     $self->{'separator'} = "\r\n--$boundary$\r\n";
---
>     $self->{'separator'} = "\r\n--$boundary\r\n";



Reproducible: Always
Steps to Reproduce:
(Assignee)

Updated

13 years ago
Blocks: 231570

Comment 1

13 years ago
Could you rediff using the unified format (diff -u) and post that as an 
attachment? Thanks!
(Assignee)

Comment 2

13 years ago
Created attachment 144762 [details] [diff] [review]
patch created with diff -u

As requested, patch created with diff -u

Comment 3

13 years ago
Ouch. A regression from bug Stephen's patch at bug 226251.
Assignee: justdave → corporate_gadfly

Updated

13 years ago
Severity: minor → trivial
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Flags: approval?
OS: Linux → All
Hardware: PC → All
Target Milestone: --- → Bugzilla 2.18

Updated

13 years ago
Attachment #144762 - Flags: review+
(Assignee)

Comment 4

13 years ago
Are you sure you meant to assign this to me? hehe.
yep, that's common practice here, bug gets assigned to the person who writes the
patch to fix it. :)  Makes it easy to figure out who the contributors are when
you look at fixed bugs. :)
Flags: approval? → approval+

Comment 6

13 years ago
Checking in Bugzilla/CGI.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/CGI.pm,v  <--  CGI.pm
new revision: 1.10; previous revision: 1.9
done
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED

Comment 7

13 years ago
CCing Stephen to make him aware of this (he wanted to push it further in CGI.pm)
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.