Last Comment Bug 238683 - Use of uninitialized value in concatenation in Bugzilla/
: Use of uninitialized value in concatenation in Bugzilla/
Product: Bugzilla
Classification: Server Software
Component: Bugzilla-General (show other bugs)
: unspecified
: All All
: -- trivial (vote)
: Bugzilla 2.18
Assigned To: corporate_gadfly
: default-qa
Depends on:
Blocks: bz-warnings
  Show dependency treegraph
Reported: 2004-03-25 12:22 PST by corporate_gadfly
Modified: 2012-12-18 20:46 PST (History)
1 user (show)
justdave: approval+
See Also:
QA Whiteboard:
Iteration: ---
Points: ---

patch created with diff -u (692 bytes, patch)
2004-03-25 12:27 PST, corporate_gadfly
goobix: review+
Details | Diff | Splinter Review

Description corporate_gadfly 2004-03-25 12:22:10 PST
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040302 Galeon/1.3.13
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040302 Galeon/1.3.13

I get tons of these errors in the error_log:

Use of uninitialized value in concatenation (.) or string at Bugzilla/
line 121

Here's a diff that takes out the extra $ sign after boundary:
Index: Bugzilla/
RCS file: /cvsroot/mozilla/webtools/bugzilla/Bugzilla/,v
retrieving revision 1.9
diff -r1.9
<     $self->{'separator'} = "\r\n--$boundary$\r\n";
>     $self->{'separator'} = "\r\n--$boundary\r\n";

Reproducible: Always
Steps to Reproduce:
Comment 1 Vlad Dascalu 2004-03-25 12:23:45 PST
Could you rediff using the unified format (diff -u) and post that as an 
attachment? Thanks!
Comment 2 corporate_gadfly 2004-03-25 12:27:16 PST
Created attachment 144762 [details] [diff] [review]
patch created with diff -u

As requested, patch created with diff -u
Comment 3 Christian Reis 2004-03-25 12:34:27 PST
Ouch. A regression from bug Stephen's patch at bug 226251.
Comment 4 corporate_gadfly 2004-03-25 13:05:12 PST
Are you sure you meant to assign this to me? hehe.
Comment 5 Dave Miller [:justdave] ( 2004-03-25 17:08:55 PST
yep, that's common practice here, bug gets assigned to the person who writes the
patch to fix it. :)  Makes it easy to figure out who the contributors are when
you look at fixed bugs. :)
Comment 6 Vlad Dascalu 2004-03-25 18:07:52 PST
Checking in Bugzilla/;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/,v  <--
new revision: 1.10; previous revision: 1.9
Comment 7 Vlad Dascalu 2004-03-28 05:31:12 PST
CCing Stephen to make him aware of this (he wanted to push it further in

Note You need to log in before you can comment on or make changes to this bug.